From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tromey@adacore.com>
Received: from rock.gnat.com (rock.gnat.com
 [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1])
 by sourceware.org (Postfix) with ESMTP id CD2493857C74
 for <gdb-patches@sourceware.org>; Wed, 16 Sep 2020 15:48:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CD2493857C74
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=adacore.com
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=tromey@adacore.com
Received: from localhost (localhost.localdomain [127.0.0.1])
 by filtered-rock.gnat.com (Postfix) with ESMTP id A0120117238;
 Wed, 16 Sep 2020 11:48:29 -0400 (EDT)
X-Virus-Scanned: Debian amavisd-new at gnat.com
Received: from rock.gnat.com ([127.0.0.1])
 by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 0kDM0cm1nrdZ; Wed, 16 Sep 2020 11:48:29 -0400 (EDT)
Received: from murgatroyd (75-166-96-88.hlrn.qwest.net [75.166.96.88])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by rock.gnat.com (Postfix) with ESMTPSA id 406D4117210;
 Wed, 16 Sep 2020 11:48:29 -0400 (EDT)
From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Make target_wait options use enum flags
References: <20200727173526.2186755-1-tromey@adacore.com>
 <ed66788a-6b5d-661f-9ed5-7cb2edd4055e@simark.ca>
X-Attribution: Tom
Date: Wed, 16 Sep 2020 09:48:28 -0600
In-Reply-To: <ed66788a-6b5d-661f-9ed5-7cb2edd4055e@simark.ca> (Simon Marchi's
 message of "Tue, 28 Jul 2020 09:31:03 -0400")
Message-ID: <87d02lafjn.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Sep 2020 15:48:30 -0000

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> This changes TARGET_WNOHANG to be a member of an enum, rather than a
>> define, and also adds a DEF_ENUM_FLAGS_TYPE for this type.  Then, it
>> changes target_wait and the various target wait methods to use this
>> type rather than "int".
[...]

Simon> Good idea thanks.

I'm going to check this in.

Note that, as I mentioned earlier, I couldn't build all targets -- I
made a best effort, but maybe I've introduced an error.  Let me know if
you hit one and I will try to fix it.

thanks,
Tom