From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WGHmMiHk2mNRhycAWB0awg (envelope-from ) for ; Wed, 01 Feb 2023 17:13:53 -0500 Received: by simark.ca (Postfix, from userid 112) id CB5901E128; Wed, 1 Feb 2023 17:13:53 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=JJsfOih+; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 60C651E0D3 for ; Wed, 1 Feb 2023 17:13:53 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9A8963858434 for ; Wed, 1 Feb 2023 22:13:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A8963858434 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675289632; bh=zGc4PLXIoLOrgrXDa9HJiPecJunKJi4oZa1hicwQpfE=; h=References:To:Cc:Subject:In-reply-to:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=JJsfOih+Y8GqQRYV5qkIViH01mE18t3SFJJr2Opq+bLbdP2p8tr/HZsgfkI60pMtf R8RZj+Uw8o4DH7FEOK6mpzZud1zGftVFn3DnCkUgt0rdcaA3S8ZSS5gq15pAF8RW1q DtHSTacjExILKTW3UlGBEFgdy4bB9+F8674AAm1M= Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id EC4CD3858D3C for ; Wed, 1 Feb 2023 22:13:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EC4CD3858D3C Received: by mail-oi1-x232.google.com with SMTP id p185so16986395oif.2 for ; Wed, 01 Feb 2023 14:13:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zGc4PLXIoLOrgrXDa9HJiPecJunKJi4oZa1hicwQpfE=; b=J3bnSSVdkZjfoNKuKugC5DQmqI7cnorNW+Ak6avFgd6fTnZN0B0KgpNx6AcoB0y8UX 3BtlDJUPGTjYx6vpPZpH9YgPcOBZo1etzVoDjnk6GvuMNjpM/6sy3lIWs2WgTJgzJOgo iVJI0ny8/P4WWFjJi9G3IS9DNb82B/Qhj4ikGycjZkn05lKr4158BBjE/wJpWI5AQ2NM oOCy+Bd6MKuit0lVxOY8YEZJvUBGQFy+S8g2x9n4BQ5jgL6tXoAcK7x+zHUDTeyd2/Oo oM7J3ZlgqJQ2sc66nD51epPEzeOxmUwTyY6Cs/wPFdcGsenahh6CLSWvnv5BNrNQNoGI pY3A== X-Gm-Message-State: AO0yUKWPvt5vwmeO69L1VIz/jDP9wojFevc93EUhSnU8UcFHoI2KBps6 e+Yqt+T2lYh0Cu0DoRTpJYggdEjdzXPtNuaB X-Google-Smtp-Source: AK7set/GtlO9TGcwGq8COp5Gr9tslQ4oNLG0T3NuD0KgvrWRNcsquSrIOZtzvJ0BhJ0yWz4XW6mVGQ== X-Received: by 2002:aca:240d:0:b0:378:6f44:2a2e with SMTP id n13-20020aca240d000000b003786f442a2emr1705869oic.46.1675289611353; Wed, 01 Feb 2023 14:13:31 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:bd06:52ef:430e:d93c]) by smtp.gmail.com with ESMTPSA id a23-20020aca1a17000000b003780facc45esm5093434oia.50.2023.02.01.14.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 14:13:30 -0800 (PST) References: <20230130044518.3322695-1-thiago.bauermann@linaro.org> <20230130044518.3322695-4-thiago.bauermann@linaro.org> <50e0d83b-ba25-e9ba-057b-207d84f732ee@arm.com> User-agent: mu4e 1.8.13; emacs 28.2 To: Simon Marchi Cc: Luis Machado , gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH v3 3/8] gdbserver/linux-aarch64: Factor out function to get aarch64_features In-reply-to: Date: Wed, 01 Feb 2023 22:13:28 +0000 Message-ID: <87cz6tkp9z.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thiago Jung Bauermann via Gdb-patches Reply-To: Thiago Jung Bauermann Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Simon Marchi writes: >> Still LGTM. > Still LGTM too. Thank you for your review! -- Thiago