From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ub2oIljHO2W7RjgAWB0awg (envelope-from ) for ; Fri, 27 Oct 2023 10:21:12 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=WSCn1DD5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7F84D1E0D2; Fri, 27 Oct 2023 10:21:12 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 348B71E00F for ; Fri, 27 Oct 2023 10:21:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 851D93860778 for ; Fri, 27 Oct 2023 14:21:09 +0000 (GMT) Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 01C1D386180B for ; Fri, 27 Oct 2023 14:20:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01C1D386180B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01C1D386180B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698416459; cv=none; b=sY5XxPhEx1caoDcT9M+dSGTbn3pkOMdyGRnJkio9j2OFL81QiKwTFbuNFkVvAqeO3lKk9YWPAsUOPXI7lEfNRddeoDD94v+hG+W2QI7q1e1bDYmNBvy/ignGxXVR0RMScFMDicAsx/qnxG3Tx4MAIn/6Nu0gEtQGwNmNXty8E6U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698416459; c=relaxed/simple; bh=rTB/cZ8m5lBJSJGZ295ilxdEFA6IPKrbp3tVsmb+m6g=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=OvLn/tlE350sphoc4BllOL1fVrL6HKqLVnjvnRyZOmOjZrvMnAA+M3TYzW4A/ec5ti5VA/vEWlONiWsLISuzUl9JixRlKZ0yU6HIK45W2Rh0YeFHgGHh3wEPQB8ZDIf8+RqsHiofKnlOd4lPeT+cAARlXhXTk7inolNfWRAZJq4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-3574297c79eso6293125ab.1 for ; Fri, 27 Oct 2023 07:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1698416457; x=1699021257; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/hqtUJXdBbXFumK5YjfoR9AB94KgiJsN1XbdOHu5k4Q=; b=WSCn1DD5+SGo0wLzjBqF9TWOABihmQJiTSCjQmQleZADAIQIMuSVv0LMMH7nyCfHNH 8Siv6goSXazGGZ+4ROpY1yHKw+Zup+obEhnmSZf8ZCGfcAjlWKhxHACDMRz0Xy+kBtz7 eF7doBD2bGpMJugsTkD1kXaRWw/cX4ngN5aHMY2bEuQq4F3GDzBPrm602bw7abkIjEQX f2Fr+8/7Dcve6Q3xt/9h1QE8DhE5VjTI8uTrBlyO4yWSoEEOmwEegCQHTQ5QFoYXv4lJ A6UixDqkX7UCTAuBo6zRT55VaRvIb5IFcnEubFwCiEIpuT3QpwIK5LRdZ5WisuB4a7Yl t7Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698416457; x=1699021257; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/hqtUJXdBbXFumK5YjfoR9AB94KgiJsN1XbdOHu5k4Q=; b=PBRXDa0ySzqg6nd+ye+zc4x6fPCkVVTbvszvowcDsDgBve9KP9PXjFFyiauYUvi+Pg f+D41aFdnyMdpYy2BT35krI8uaFGdxl+ZjYp59EBU7jgaUwcGDPwUwK2lMFM0AQJ8yuQ DqpTChGafpTEpVfwbp7AzwpiZvCkhQn+PQY87TdnTQK/UAXBfiag7V8YjYzDl890uLac 53KBqkc+oq/rJt05VYZHi6708Ee1w/GM38hGdjIbp7jSpDXgywrjEiIpr9cCbnfPO6Sg 6nY8niJy8WQS9MXUf55xf/Cu7mduxwX3E/UxU59ucjXDY9MfK6vZnQW36sHdthpkf0J0 GfDQ== X-Gm-Message-State: AOJu0YyYRLBCLM8NQzQ2gxwwWWOv+P9DHEettme5UfCrCLvMYgrGgizr 6YiVWW1sTj/8O4FSejx/cHkHeJKs49eRhU3gDqp/sA== X-Google-Smtp-Source: AGHT+IF4AOkXrELdhigksUZmJRwaRHlcmZjBFxPrk9A7U6Or/hVplvx1F+HRvkH8l5ETWK9dEwndFw== X-Received: by 2002:a05:6e02:1bac:b0:357:fb77:63bf with SMTP id n12-20020a056e021bac00b00357fb7763bfmr3641610ili.24.1698416457201; Fri, 27 Oct 2023 07:20:57 -0700 (PDT) Received: from murgatroyd (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id r13-20020a056638044d00b0045b8d5a9262sm443884jap.11.2023.10.27.07.20.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 07:20:56 -0700 (PDT) From: Tom Tromey To: Lancelot SIX Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] Remove byte vectors from cplus_struct_type References: <20230921-field-bits-v1-0-201285360900@adacore.com> <20230921-field-bits-v1-3-201285360900@adacore.com> <20230925223241.phor5lusw7jd4flf@octopus> X-Attribution: Tom Date: Fri, 27 Oct 2023 08:20:56 -0600 In-Reply-To: <20230925223241.phor5lusw7jd4flf@octopus> (Lancelot SIX's message of "Mon, 25 Sep 2023 23:32:41 +0100") Message-ID: <87cyx0m9iv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Lancelot" == Lancelot SIX writes: >> + /* Whether the field is 'private'. */ >> + bool m_private : 1; >> + /* Whether the field is 'protected'. */ >> + bool m_protected : 1; Lancelot> Is there a reason I miss to not use an enum to describe the visibility? Lancelot> This would avoid having to verify that m_private and m_protected are Lancelot> mutually exclusive. I changed this in v2. >> case VISIBILITY_PROTECTED: >> + newobj->field.set_private (); Lancelot> I think this should be: newobj-> field.set_protected (); I fixed this too. Tom