From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6NNICsETBGfJ9AQAWB0awg (envelope-from ) for ; Mon, 07 Oct 2024 13:00:49 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ad4S5SaM; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2260F1E355; Mon, 7 Oct 2024 13:00:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7AA351E05C for ; Mon, 7 Oct 2024 13:00:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 03FF9385C6C0 for ; Mon, 7 Oct 2024 17:00:48 +0000 (GMT) Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 18C46385C6C1 for ; Mon, 7 Oct 2024 17:00:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 18C46385C6C1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 18C46385C6C1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728320427; cv=none; b=qvzjl0DbBwgUC9trMZfLXL9NaNtaO5NwV3zmewA41C+w3t5pHcBGCQn839bIVFqKqeAP0OcxxDFfbYzDKYUYpbpisqOEdiADG330Q5ipFlN//w0JjHNZPD+eJlDx8BkUlIqXOaaGEn0pDAxinilnQe9e8SOSoHEF48VbswlIV4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728320427; c=relaxed/simple; bh=x7EFweUpvXouNVLm5eP0s5CKWX0GLfNVOfTGDiCBqCc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FzWxgXjlLOrUpEbigLBz2G/pLAX51TBqQ/SpVSlVaqM7RTl53qSsIVEpTjlCMSNyDSUpAxcrQcwpg1XstBC4z6W2detnMu8X5mPoxvSkgbGWpqoIZt7UbjoMafvqeSwAKJEVLV5CALSDo8hhId1bTyHfsdv1QosyPvJSyCpgMFg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5006a.ext.cloudfilter.net ([10.0.29.179]) by cmsmtp with ESMTPS id xfdBsqjrO1zuHxr5tsoxND; Mon, 07 Oct 2024 17:00:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xr5ssnVCO3nDKxr5tsLwQO; Mon, 07 Oct 2024 17:00:25 +0000 X-Authority-Analysis: v=2.4 cv=T6iKTeKQ c=1 sm=1 tr=0 ts=670413a9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=DAUX931o1VcA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=cbei6QyMmA1JfScsa50A:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Nc7pPND26zSVVnXo5UtcvTaPrJZaLdgekXsiv/Cwd+U=; b=ad4S5SaMl3WrL2ytk3jVtx39+C xquoah7pn/MPv6X2R7SIw8uPo6R5Vod7OAwViHR4MBuo0B5N7AyBvuGYvlSb2rKO+zw8RWwPqNT+J Ra12pN+afgXyb4uRLqDmNoAgs; Received: from 97-122-122-36.hlrn.qwest.net ([97.122.122.36]:45400 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1sxr5s-002zuu-19; Mon, 07 Oct 2024 11:00:24 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] gdbserver: make arch and osabi names gdb::unique_xmalloc_ptr In-Reply-To: (Andrew Burgess's message of "Sun, 6 Oct 2024 19:37:05 +0100") References: X-Attribution: Tom Date: Mon, 07 Oct 2024 11:00:23 -0600 Message-ID: <87cykbetlk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.122.36 X-Source-L: No X-Exim-ID: 1sxr5s-002zuu-19 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-122-36.hlrn.qwest.net (murgatroyd) [97.122.122.36]:45400 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfILHqZdLR/N4REI5ZecANVg6jy7YUcCCG3TcD9dGeIl0QgratiYmjw8ZGFqaNGDdBfgqrj/iWMUKHVeOOp3AM520MPpWQcv+/O38dBKVNJj2js4OJd+s 5pj87bsCWp+pCIzG06yiHUA9Ak0qy6iNz6ZzSBfmC/I/YGnlTdLEhJ0J3Sba9f+JyuanvX8d3hNowX0riPx6c0zT9E0k02ZDi7I= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> Convert target_desc::arch and target_desc::osabi from 'const char*' to Andrew> gdb::unique_xmalloc_ptr. This also allows us to remove the user Andrew> defined ~target_desc destructor. Andrew> I doubt it ever actually occurred, but in theory at least, there was a Andrew> memory leak in set_tdesc_architecture and set_tdesc_osabi where the Andrew> member variables were assigned without freeing any previous Andrew> value... but I suspect that usually these fields are only set once. Andrew> There should be no user visible changes after this commit. Looks good to me, thank you. Approved-By: Tom Tromey Tom