From: Tom Tromey <tom@tromey.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 01/11] Don't attempt to find TLS address when target has no registers
Date: Thu, 19 Dec 2024 14:36:17 -0700 [thread overview]
Message-ID: <87cyhn9wz2.fsf@tromey.com> (raw)
In-Reply-To: <20241106192517.206988-2-kevinb@redhat.com> (Kevin Buettner's message of "Wed, 6 Nov 2024 12:21:37 -0700")
>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
Kevin> + {
Kevin> + if (!target_has_registers ())
Kevin> + error (_("Cannot read `%s' without registers"),
Kevin> + var->print_name ());
Kevin> + addr = target_translate_tls_address (obj_section->objfile, addr);
I wonder whether target_translate_tls_address should do this check.
Tom
next prev parent reply other threads:[~2024-12-19 21:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 19:21 [PATCH v4 00/11] GDB-internal TLS support for Linux targets Kevin Buettner
2024-11-06 19:21 ` [PATCH v4 01/11] Don't attempt to find TLS address when target has no registers Kevin Buettner
2024-12-19 21:36 ` Tom Tromey [this message]
2024-11-06 19:21 ` [PATCH v4 02/11] Allow TLS access to work in gdb.server/no-thread-db.exp Kevin Buettner
2024-11-06 19:21 ` [PATCH v4 03/11] Track and fetch TLS module ids for MUSL and GLIBC Kevin Buettner
2024-11-06 19:21 ` [PATCH v4 04/11] Implement internal TLS address lookup for Linux targets Kevin Buettner
2024-11-06 19:21 ` [PATCH v4 05/11] Internal TLS support for aarch64, x86_64, riscv, ppc64, and s390x Kevin Buettner
2024-11-06 19:21 ` [PATCH v4 06/11] Internal, but disabled, TLS support for i386 Kevin Buettner
2024-11-06 19:21 ` [PATCH v4 07/11] Delete disabled i386 internal TLS support Kevin Buettner
2024-11-06 19:21 ` [PATCH v4 08/11] New test - gdb.base/tls-nothreads.exp Kevin Buettner
2024-11-06 19:21 ` [PATCH v4 09/11] New test - gdb.base/tls-multiobj.exp Kevin Buettner
2024-11-06 19:21 ` [PATCH v4 10/11] New test - gdb.base/tls-dlobj.exp Kevin Buettner
2024-11-06 19:21 ` [PATCH v4 11/11] Add TLS NEWS entry and document 'set force-internal-tls-address-lookup' command Kevin Buettner
2024-11-07 5:38 ` Eli Zaretskii
2024-11-27 17:36 ` [PATCH v4 00/11] GDB-internal TLS support for Linux targets Kevin Buettner
2024-11-27 18:59 ` Eli Zaretskii
2024-11-30 23:11 ` Kevin Buettner
2024-12-12 23:20 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyhn9wz2.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox