From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fBLnDSoaOmgzCTsAWB0awg (envelope-from ) for ; Fri, 30 May 2025 16:50:50 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=RrR8c8j8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2559B1E102; Fri, 30 May 2025 16:50:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 787DF1E0C2 for ; Fri, 30 May 2025 16:50:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 099893858D29 for ; Fri, 30 May 2025 20:50:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 099893858D29 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=RrR8c8j8 Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id AE6EF3858D20 for ; Fri, 30 May 2025 20:50:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE6EF3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AE6EF3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748638213; cv=none; b=l4LUxZrhWDYx7vu9mTs4FMVfVWeLNv1LKRnmYjGcMTOsSfUtIljKTrt7aZ7wv6gpKzz2A59sM0P+2HA3BClJMibk6lUn6pPZ18WTveImWMJhI/TxdZDIjpM4roeMpjD7si2DR9NbfEFnMVZ7RD91dSf2lhkXjStVDF+yqdTQuqU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748638213; c=relaxed/simple; bh=6QI9/3rdHAfkzHXZ2SFNDvFNyOMsZmrRR0K9kfcP4pY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PpufdBbJKpaFdWcj7r6Ggl7tl68RfRFwOfOuXgl9A2z3+DujeozvSz75YAySilo1BGrdGVan5tmyNesFJm4iWiyUgbGhWdKdatJsdO/IHwzNzltVGXlIx2nQsVW0nmUn3l4LBd7PkhvT3zC3mI6Cno70G7zFb2Ab9SOpaFF3M/8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE6EF3858D20 Received: from eig-obgw-6005a.ext.cloudfilter.net ([10.0.30.201]) by cmsmtp with ESMTPS id L3oiu5BHWAfjwL6g8u9A5q; Fri, 30 May 2025 20:50:12 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id L6g8utqQkZ6h1L6g8uucbA; Fri, 30 May 2025 20:50:12 +0000 X-Authority-Analysis: v=2.4 cv=ergUzZpX c=1 sm=1 tr=0 ts=683a1a04 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dt9VzEwgFbYA:10 a=ItBw4LHWJt0A:10 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=DFX-C-PcR4CJlzNsk2UA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ed8imjwqPUdRynm4Fkn8hnJXmmbCsVe3GvQBc1cgm6c=; b=RrR8c8j8h6rLyuSxpvQauJHrBh htlUwNS35a/mFM+gqfdLASKkTSQXRRKd2pKtbjWKPHB7wFJlgC6pcHTa5size5DjyvEx1kYOaO9OA d4CO97Tj6Q0TglyXPpp8Tni37; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:41716 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uL6g7-00000002Ecq-34Jz; Fri, 30 May 2025 14:50:11 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 41/47] Windows gdb: Watchpoints while running (internal vs external stops) In-Reply-To: <20250519132308.3553663-42-pedro@palves.net> (Pedro Alves's message of "Mon, 19 May 2025 14:23:02 +0100") References: <20250519132308.3553663-1-pedro@palves.net> <20250519132308.3553663-42-pedro@palves.net> X-Attribution: Tom Date: Fri, 30 May 2025 14:50:10 -0600 Message-ID: <87cybp258d.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1uL6g7-00000002Ecq-34Jz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (bapiya) [97.118.46.156]:41716 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKONDHUjRrBMeJqebrIIHaY3l+XWkYfJUz/gIDmQ9uXLpu0fiAMDjb9HOu1KnMGv7rF5rKcjDeoXUnCo64rwd2cKwANdGUzrskJJXma0WJQ9IbV7P/s7 GPekhbOt3n67ieqjKChlopy3+3kGh1OdvXaMkHO47diEZdm18dLEoVjKfY5W2rUGJvXIUIImdJCLDGoYkbpoty+zHl7h+k597zk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Pedro" == Pedro Alves writes: Pedro> Teach the Windows target to temporarily pause all threads when we Pedro> change the debug registers for a watchpoint. Implements the same Pedro> logic as Linux uses: [...] I doubt I'll be able to understand this particular patch without debugging it myself or something, but I read through it and didn't see anything obviously out of wack. Pedro> and DR7. Defering the actualy writes to ::wait avoids a bunch of s/actualy/actual/ Pedro> +static void Pedro> +debug_registers_changed_all_threads () Pedro> +{ Pedro> + auto *win_tgt = static_cast (get_native_target ()); Probably checked_static_cast? Reviewed-By: Tom Tromey Tom