Re: [PATCH 7/7] [gdb/testsuite] Add Term::get_string_with_attrs in tuiterm

Tom de Vries
2025-07-24T10:08:01Z

On 7/23/25 20:36, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> + # Return the text of screen line N. Lines are 0-based. Start at column
> Tom> + # X. If C is given, stop before column C. Columns are also zero-based.
> Tom> + # If ATTRS, annotate with attributes.
> Tom> + proc get_string {n x c {attrs 0}} {
>
> The comment here (and the other ones later in the patch) make it sound
> like C is optional, but it isn't.

Thanks for the review.

Fixed by using "non-empty" instead of "passed", and pushed.

- Tom