Re: [PATCH 5/7] [gdb/testsuite] Fix Term::_csi_m with no args

Tom de Vries
2025-07-23T20:34:27Z

On 7/23/25 20:30, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> When calling Term::_csi_m with no args, default behaviour needs to be applied,
> Tom> which is equivalent to "Term::_csi_m 0" [1].
>
> Tom> However, while "Term::_csi_m 0" works, as well as 'Term::_csi_m ""', calling
> Tom> Term::_csi_m with no args has no effect.
>
> Tom> Fix this by implementing the default behaviour in Term::_csi_m.
>
> Ok.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom> + set args { 0 }
>
> The spaces seem mildly unusual since I don't think they'd be in a "real"
> argument of just "0".

Hi Tom,

thanks for the review(s).

Yes, sorry about that. I keep getting tripped up about the tcl string
vs list confusion.

I added the spaces for readability, which doesn't matter when regarding
args as a list, but it does when treating it as a string.

Fixed by used [list 0] instead.

Thanks,
- Tom