Re: [PATCH 4/8] gdb/xcoffread: remove xcoff_symfile_info::{symtbl, symtbl_num_syms}

Simon Marchi
2026-01-09T02:05:38Z

On 2026-01-08 17:17, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> Simon> + /* Seek to symbol table location. */
> Simon> + if (int ret = bfd_seek (abfd, symtab_offset, SEEK_SET);
> Simon> + ret < 0)
>
>>> 'ret' doesn't really seem to be needed here.
>
> Simon> What do you mean, not needed? Don't we want to check the return value
> Simon> of bfd_seek?
>
> I just mean the variable, so:
>
> if (bfd_seek (...) < 0)
>
> Tom

Oh, silly me, make sense. I'll change that and push the series, thanks.

Simon