[PATCH 7/8] gdb/xcoffread: replace 2 switches with if

Simon Marchi
2026-01-08T19:36:41Z

Replace these 2 switches that have only one case with a single if
statement. It is highly unlikely that we'll ever need to check for
other values.

Change-Id: I6a48d4f27ba4d1d128aaa39d5f3d693a11e99fc9
---
gdb/xcoffread.c | 26 ++++++++++----------------
1 file changed, 10 insertions(+), 16 deletions(-)

diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index 5494bb0debbb..5ec7281b683b 100644
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -188,24 +188,18 @@ scan_xcoff_symtab (struct objfile *objfile)
else
csect_aux = main_aux[0];

- switch (csect_aux.x_csect.x_smtyp & 0x7)
+ if ((csect_aux.x_csect.x_smtyp & 0x7) == XTY_SD
+ && csect_aux.x_csect.x_smclas == XMC_TC0)
{
- case XTY_SD:
- switch (csect_aux.x_csect.x_smclas)
- {
- case XMC_TC0:
- if (toc_offset)
- warning (_("More than one XMC_TC0 symbol found."));
- toc_offset = symbol.n_value;
+ if (toc_offset)
+ warning (_("More than one XMC_TC0 symbol found."));
+ toc_offset = symbol.n_value;

- /* Make TOC offset relative to start address of
- section. */
- asection *bfd_sect
- = xcoff_secnum_to_section (symbol.n_scnum, objfile);
- if (bfd_sect)
- toc_offset -= bfd_section_vma (bfd_sect);
- break;
- }
+ /* Make TOC offset relative to start address of section. */
+ asection *bfd_sect
+ = xcoff_secnum_to_section (symbol.n_scnum, objfile);
+ if (bfd_sect)
+ toc_offset -= bfd_section_vma (bfd_sect);
break;
}
}
--
2.52.0