Re: [PATCH v2] Remove best_symbol and better_symbol

Tom de Vries
2026-02-08T10:46:51Z

On 2/8/26 2:06 AM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> On 2/7/26 3:39 PM, Tom Tromey wrote:
>>>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
> Tom> This patch removes best_symbol and better_symbol.
>>> [...]
>>> I'm going to check this in now.
>
>
> Tom> I'm seeing regressions due to this commit. For instance, in test-case
> Tom> gdb.base/condbreak-call-false.exp:
>
> Sorry about that.
> I will debug it ASAP but if you want you can back it out.

I've:
- filed a PR ( https://sourceware.org/bugzilla/show_bug.cgi?id=33884 ),
- did some investigation which I posted in the PR, and
- reverted the commit (
https://sourceware.org/pipermail/gdb-patches/2026-February/224833.html ).

I've reverted for my convenience, I don't know if others are affected as
well.

Thanks,
- Tom