Re: [PATCH v2] Remove best_symbol and better_symbol

Tom de Vries
2026-02-07T23:17:22Z

On 2/7/26 3:39 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> This patch removes best_symbol and better_symbol.
> [...]
>
> I'm going to check this in now.

I'm seeing regressions due to this commit. For instance, in test-case
gdb.base/condbreak-call-false.exp:
...
(gdb) PASS: gdb.base/condbreak-call-false.exp: break bar
c^M
Continuing.^M
Error in testing condition for breakpoint 2:^M
Invalid data type for function to be called.^M
^M
Breakpoint 2, foo () at
/data/vries/gdb/src/gdb/testsuite/gdb.base/condbreak-call-false.c:25^M
25 return 23;^M
(gdb) FAIL: gdb.base/condbreak-call-false.exp: c
...

Thanks,
- Tom