From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kapiDQH/smldRSYAWB0awg (envelope-from ) for ; Thu, 12 Mar 2026 13:59:29 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kxeCSWwH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 326411E0DD; Thu, 12 Mar 2026 13:59:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 71C7E1E089 for ; Thu, 12 Mar 2026 13:59:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C9F774BC056E for ; Thu, 12 Mar 2026 17:59:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C9F774BC056E Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kxeCSWwH Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 68EA14BB58A1 for ; Thu, 12 Mar 2026 17:59:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68EA14BB58A1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 68EA14BB58A1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773338340; cv=none; b=S2J3Y5wjLj/2kiBMIk0RkKAQy1Y4zCSAHv1VGvJdv9ac5fT9DJ5gidaIn+sYUZJ4pGg96lDWx11m1pcCe5v6lWuQieIHgXKtlMCjrnTp1YM7qVFwtO+3PfkNAcJuniNXyu6gFvkyjxf4dDNlNnHsyrFHaN06sre4piDkvH0VYdk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773338340; c=relaxed/simple; bh=9yfHnFqaAe+pW+zBdN4Wnvj0mc9vLU9eNixfmrzdloc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eunmnv8e5aOF9pVygxLi3EUpM9Hfaf8uKDd7RCk8N847UqQjzB+9Zm0xjWD6fnjnXlBHY/xrQTt1cR0405r977t7ffqADUA4K1E+w+O99997m3bbF1q6E5Kw6vYS8wsm1dhk0P2C7fjrEFuCa19E7wXCVN7hOoONpfmUXCXolhw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 68EA14BB58A1 Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id 0a1bwxVXYKjfo0kJHwsDmm; Thu, 12 Mar 2026 17:58:59 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 0kJDwq2v8SqlV0kJEwPaGB; Thu, 12 Mar 2026 17:58:56 +0000 X-Authority-Analysis: v=2.4 cv=I7FlRMgg c=1 sm=1 tr=0 ts=69b2fee3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=pGLkceISAAAA:8 a=qOf8s-XEDrzFCExexSgA:9 a=QEXdDO2ut3YA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KZDP7fdqgpazxvE9EXdreRGEbrsSqpLK8gqNMgMe+eY=; b=kxeCSWwHBl4W5T1VWI8XYai60R MDbTpzqK0FD5YDtqdcp96iNNnEHcSV/KYlGEE2qkgjqF6EIwi3JZNHtDXMLjX/pf8ouf2howK/lJY ZNf0CsPhH9v/1KkcAxc57hJAt; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:47014 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w0kJD-00000000EmK-1ozN; Thu, 12 Mar 2026 11:58:55 -0600 From: Tom Tromey To: =?utf-8?B?SsOpcsO0bWU=?= Duval Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/8] gdb: Update Haiku support for 17.x In-Reply-To: <20260312172336.15450-6-jerome.duval@gmail.com> (=?utf-8?B?IkrDqXLDtG1l?= Duval"'s message of "Thu, 12 Mar 2026 18:23:33 +0100") References: <20260312172336.15450-1-jerome.duval@gmail.com> <20260312172336.15450-6-jerome.duval@gmail.com> X-Attribution: Tom Date: Thu, 12 Mar 2026 11:58:54 -0600 Message-ID: <87cy19rktd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1w0kJD-00000000EmK-1ozN X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:47014 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLwQToJLtqTAWEGGwsYWbwSlQ6fuR+zEt4a1SZE72wGLTuD2UMFmgk/AB9dFgxx2KMxU3f9+PY7/6QrQZPZxA6Sv0Y5NM7TEpgRq0nU/oGU+82TN1ARe 739a0IDQxuz5R+Y+BmD8+RtmLVSHhf06EULyfX4ym3diKXuITHA3sPI95tDTFu1oKrGWpfqheMFoiSU0gQbqpFxRcx+YwmTTPtE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "J=C3=A9r=C3=B4me" =3D=3D J=C3=A9r=C3=B4me Duval writes: I chose this one to make a note on (see below), but also I wanted to make a more general request -- In gdb we strive to have commits be bisectable. So while I think what you did here -- having separate patches to upgrade to different baseline gdb versions -- makes a great deal of sense when working out-of-tree, for landing in gdb it would be better to squash these commits into the appropriate spot in the series. Like I guess keeping the gdb/gdbserver commits separate makes sense (at least from a gdb perspective, I didn't really closely examine the patches). Hope that makes sense. J=C3=A9r=C3=B4me> + /*else J=C3=A9r=C3=B4me> { J=C3=A9r=C3=B4me> - solib_target_so_ops.relocate_section_addresses (so, = sec); J=C3=A9r=C3=B4me> - } J=C3=A9r=C3=B4me> + solib_target_so_ops::relocate_section_addresses (so,= sec); J=C3=A9r=C3=B4me> + }*/ J=C3=A9r=C3=B4me> } Also in gdb we generally don't land commented-out code. There is some in the tree already (basically every rule is violated somewhere in the tree) but we try not to add new instances. So these should just be dropped from the patches, or resurrected if that's more appropriate. thanks, Tom