From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id r8LlJss2zmlsuwMAWB0awg (envelope-from ) for ; Thu, 02 Apr 2026 05:28:43 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RaIuEg3d; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 90CF51E0BC; Thu, 02 Apr 2026 05:28:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 398141E04F for ; Thu, 02 Apr 2026 05:28:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 7E9D64BA23C3 for ; Thu, 2 Apr 2026 09:28:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7E9D64BA23C3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RaIuEg3d Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 43FBE4BA23C3 for ; Thu, 2 Apr 2026 09:28:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43FBE4BA23C3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 43FBE4BA23C3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775122097; cv=none; b=q0St3mDc+9H9S0Y8Mu6mZqWiYVw8eMasoEZiI/VUweXuGuIw4OQz2p3BzieResmDVW0M6BDIoChHLzKiYYZ1Q1DVpp1ASBMUME5j3t+7WHfJ454syKLYtYjTEXc8NVSe83Yl8O4XV+BprG4dhiwKTQ4whg8jvpo3E3YMg491m1g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775122097; c=relaxed/simple; bh=plF6jldlLw9FB7XJgtRZqiJsDvY/6zHFUjNSFf8tDwU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=M+M59htQYGH3NiqQ1c5LDKn6vk17j533aVAyIXoJtjpZiVDkcUjPq3YJCTrQqHrwEZrzuG9k2FUBvZsVY9RJoN1yfqTlbKVNF2Hel8hnaEltCb3Zif/BR4nEc0DtU6cr4jw197wT626RjuX4ovBGNmYfVr/y6cJvTiVj/WtDblE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43FBE4BA23C3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775122096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2uFKkV5b2+r26nz9XrV7sU2UKAsBjn7Ntz/AqhpyUhE=; b=RaIuEg3dlx7frWF7GynCnieSY+2m9G3jBfjHAhsnwhkSoev923/qoTulObBIpfPWVACyEH 5OxaEgDMT4AHEf9SkfHY/FSQTyXRlleemWwR84vEMnagyZsj7LcwWNGU4ZRHBzAEc5eCIO Z/FxYp8hJe24JPj8OkWUUXm+X6OtKo8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-102-v06KV5BYPPG-gN_lYhN7dA-1; Thu, 02 Apr 2026 05:28:15 -0400 X-MC-Unique: v06KV5BYPPG-gN_lYhN7dA-1 X-Mimecast-MFC-AGG-ID: v06KV5BYPPG-gN_lYhN7dA_1775122094 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4853466655dso5649055e9.3 for ; Thu, 02 Apr 2026 02:28:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775122094; x=1775726894; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2uFKkV5b2+r26nz9XrV7sU2UKAsBjn7Ntz/AqhpyUhE=; b=UrBmRRFWYzqQEu+Fkdz8DIBZr8PnLD+ibtSOtytsx/o8/qgkGZUrHhrG85neyaEfdS do3o1w22Kg7uECUmpA6qOoVDNBqAYdVatTpJI/UzYxA1IAwyPV60yIOkWmAVpg279Na3 Iz4WLnLjoPDvhsx6tB0BxnG0KvPQ9pFk8FzNVd75MWaldnKfgNb6Y5ofszw1OGf7qD0j qZ+moMKhUkYtbZv9Y7p/OcggPIJwT564vZRosE67qyr3RxNPVm3V6eCNVTgZ6Ay0AQoe pwYJ6VilUhI/MUPKJc4Bl2W5Lh1mkFIKMJggclo2NsBYfOe7Rqwl+fUD3v1UiRzOkOub ZBog== X-Forwarded-Encrypted: i=1; AJvYcCXlOckh5r5o0hjZ6MxF/+WgAYft4dMgAhT3oLsibvJ2hR3DiT3i5EB4AVI/oZJ4ryK4nftO2lochL647w==@sourceware.org X-Gm-Message-State: AOJu0YwmJJP+ydqGiiVJuroo+t7OJtaP4z20/mTQJWAnrwuttaC5PZSD PFM/DISIUDMOdqesKb+0O3qei/fy4Cr14oO0dlfBBLADWZbnhiWrBwJrGQRAgc+lGhy8Y8Wzue6 PVohEUtEgnCTmdqxXDAu4yzbnSeuIn+mXN+uwo4ZSnZy8qKh4zM2ulrIgIQXg9jCxjXN8Bvo= X-Gm-Gg: ATEYQzzC94Ga1iM4416UarsvUMz+5ByizNukqASWoesVUPjmnLOyrV4mWevGET6WqFd +3BhTgeDOFcK4NLNhdC5TARxZU/6B1wepEWFvp65nuLDd8hhO/GgpbkNyYwKrbW/MD0qsxr7QBs +Cv7y2ilnDnu4UZyxZZqlG6wPTQHxHAYKPZckCmsSX6y+HaRcWzfWgD1bdSCdns8hh2OCoAIgZe XpsATS+Xk0XVYIPnI1MRf4bbzLdcnrysK4OaBRAQLcKVOPHB0EBsU6S504WGWJU5RSOpF/Wxscu 28XldCTI4sJvncecxG92fnSmBuIftkgprfsf3wyAcfTR2dKKYjgp3FfnXDXIxl/V4jzhkbmh4Iz xl02mGKRYMhBd0s+F X-Received: by 2002:a05:600c:c494:b0:486:d76c:fa21 with SMTP id 5b1f17b1804b1-488835712e5mr115960155e9.12.1775122093726; Thu, 02 Apr 2026 02:28:13 -0700 (PDT) X-Received: by 2002:a05:600c:c494:b0:486:d76c:fa21 with SMTP id 5b1f17b1804b1-488835712e5mr115959875e9.12.1775122093240; Thu, 02 Apr 2026 02:28:13 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4888a567bfasm125065485e9.0.2026.04.02.02.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 02:28:12 -0700 (PDT) From: Andrew Burgess To: Kevin Buettner , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: move call to clear_symtab_users out from finish_new_objfile In-Reply-To: <20260401102106.463912ae@f42-zbm-amd> References: <20260401102106.463912ae@f42-zbm-amd> Date: Thu, 02 Apr 2026 10:28:12 +0100 Message-ID: <87cy0h679v.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: S5NoGL-Ma-1cdZwIMcOxSmZ7S8KaMITq6aigpFcffPE_1775122094 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Kevin Buettner writes: > Hi Andrew, > > Both parts LGTM. I have just one nit... > > On Tue, 31 Mar 2026 15:20:18 +0100 > Andrew Burgess wrote: > >> + set_auto_load_safe_path $remote_python_file \ >> + [file dirname ${objcopy_binfile}] >> + gdb_load $objcopy_binfile > > I'd like to see a comment added for this call to > set_auto_load_safe_path, perhaps something like: > > # Add directory because scripts are auto-loaded from the separate > # .debug file (not the main executable), which resides alongside > # it here. > > For both parts: > > Approved-by: Kevin Buettner I added a comment as you suggested, and pushed these patches. Thanks, Andrew