From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eWcqAB5PB2pxnz0AWB0awg (envelope-from ) for ; Fri, 15 May 2026 12:51:42 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=LAmBXTQH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EF0BD1E0B1; Fri, 15 May 2026 12:51:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C89401E067 for ; Fri, 15 May 2026 12:51:40 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5405B4B19716 for ; Fri, 15 May 2026 16:51:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5405B4B19716 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=LAmBXTQH Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id B00564BA23CE for ; Fri, 15 May 2026 16:51:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B00564BA23CE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B00564BA23CE Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778863873; cv=none; b=ttgpI7i2CE0J0QzFxFq/oZjvQ1JTJDxXwIVU43U1aQsbz1LcLRi3Z0O2PAegIpGZ5Mm3wToyYS6yvioYnxLQk1bc7/4HdGI4HLVjoSvlGtIMKk73aGHeRFeAswXMvGIYOhCb/xXElxBHRy/q9mPjrDnYRVB1n99NweG/P7xMxto= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778863873; c=relaxed/simple; bh=qzjjEuWV+jaPjJZjStsNP3fsnWWN9C1vjArhdWjx488=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=l/DvnEzOtjbeB0qWSvS8pE3RMUGFVoABEAV2O6ovWxbj5VG6S8dMMXB3SBEHtr9mlgLFg4hXLb/DlQ5ZPdkiMJFqrSikx7vMUHu8LtOt68l+PpkAe7WPcZyWbWMgkV7wptMTF5hQ1TLBJ3vN+qaNTXNCXX11hedWaetKw/URNv0= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=LAmBXTQH reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B00564BA23CE Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id NvGpwdsTmnv6VNvknwH6CY; Fri, 15 May 2026 16:51:13 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id NvkmwHWH4ZYlBNvkmwSTcd; Fri, 15 May 2026 16:51:12 +0000 X-Authority-Analysis: v=2.4 cv=MJRgmNZl c=1 sm=1 tr=0 ts=6a074f01 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=NhbUvXTsqapqGNl_pOoA:9 a=a-qgeE7W1pNrGK8U0ZQC:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iQ/pmrl89fHhLNcN0RE7JDtIegn/Gp6Q2WNf1b5GW/0=; b=LAmBXTQH41L4dHRT7qYYJKcHu1 4QLRVUMRKsdW46zJvd5/TLlXcdv5OT7fNH/qake1bfx94S1TM+q/DFfxjpdT3TAYKqZcJB1OHhZ3f knNNmKWkd6IJnr8bHUOHbwc6r; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:43598 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wNvkl-00000000wws-3StF; Fri, 15 May 2026 10:51:11 -0600 From: Tom Tromey To: Matthieu Longo Cc: , Tom Tromey Subject: Re: [PATCH v2 2/4] gdb/python: eval_python_command returns result of the evaluation In-Reply-To: <20260428162416.511367-3-matthieu.longo@arm.com> (Matthieu Longo's message of "Tue, 28 Apr 2026 17:24:14 +0100") References: <20260428162416.511367-1-matthieu.longo@arm.com> <20260428162416.511367-3-matthieu.longo@arm.com> X-Attribution: Tom Date: Fri, 15 May 2026 10:51:10 -0600 Message-ID: <87cxywipkx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wNvkl-00000000wws-3StF X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:43598 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFy7jckvjHyev0NroxA4qsdbuiZI8PkeMa0lK5fypS2cUwdi0C4qYxV32aZGwnwDM0/zrUSyYEHIKwcIcdlci40/xEcfHT0HpID5UPPWDc0QtmkA3l5V pBjrLl8zwmF0FPr5cEWIIuJxyqatVF5xQGEkQ5dwOrWxNRsO6fIQhUxXlzSEyd8H+COFhH5uTNqW9hDAII5OdudoPdDJ3vCIRn4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Matthieu Longo writes: > +++ b/gdbsupport/gdb_ref_ptr.h > @@ -179,6 +179,11 @@ class ref_ptr > return m_obj; > } > + operator bool () const noexcept > + { > + return m_obj != nullptr; > + } gdb is normally explicit instead, and since there aren't many call sites I think this operator should be dropped and those spots updated to check against nullptr. Tom