From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lsxpIB9NpGp5EwEAWB0awg (envelope-from ) for ; Fri, 11 Sep 2026 14:49:03 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VMH8iSvQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 708C71E09E; Fri, 11 Sep 2026 14:49:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BEF4E1E033 for ; Fri, 11 Sep 2026 14:49:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4799548EFB79 for ; Fri, 11 Sep 2026 18:49:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4799548EFB79 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VMH8iSvQ Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id C4E1C48FBC84 for ; Fri, 11 Sep 2026 18:48:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C4E1C48FBC84 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C4E1C48FBC84 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789152518; cv=none; b=I10IqD2sq63gML3i6yI9+yAXnFDYJMgUa8Hds0KiL7Qs7bV/lW8iMV4e/0MxBmxxvTdPbQ2UsOGdvN11Gq19c3yNeSSmW/3RCUpz3fGaPl4waMPDfSP2zAWEKI8bsQcGoS+bEpgcpbQVZ0MWt/spQk+Gzsfohugckg5XnGwO4Ec= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789152518; c=relaxed/simple; bh=Y4OvzD2D9mkPRTWInkkMe5eN0zLiOurq+SKqOpEOlIw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=R+2LfpHZgeuO7iejcymDpTmi4MpAUW6nWTYAXcr63otXkwlxMQPn1qUJeeURJpdWksuNRIeXVuAIjX6/0SZI2yTLrtDAQTLAeQ4CgO76gdi5CyWKkP8EHFLsFM4pPT5QrRGeNsVtOPVEp1eaJfYgCSeb12nps+UHFDET6oN0Kug= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VMH8iSvQ reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C4E1C48FBC84 Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id 53p8x7HgRuFzg56IgxJde6; Fri, 11 Sep 2026 18:48:38 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 56IexYSdPfDqY56IexWYms; Fri, 11 Sep 2026 18:48:36 +0000 X-Authority-Analysis: v=2.4 cv=HKbDFptv c=1 sm=1 tr=0 ts=6aa44d05 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=qSRaSNSV4QeRNsy7FxkA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=763N+a0B2n7idVD0o9hs2qyxdW9b39Z/sVQm0VbqfmY=; b=VMH8iSvQ1EPnAbzdczdjIEApnm qw+nTDJCBrFLAZHb8HRR4bRCiZNd2Au4xe1AJUANq2swwWvR91dhvxF6U/Gh2o1iugmay4aSDqtWA SNPmzkU1th/bRczTo2EBE5V4l; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:35980 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x56Ie-00000002AMz-069U; Fri, 11 Sep 2026 12:48:36 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 7/7] [gdb/tui] Handle section holes when backward disassembling In-Reply-To: <20260909094849.2745086-8-tdevries@suse.de> (Tom de Vries's message of "Wed, 9 Sep 2026 11:48:49 +0200") References: <20260909094849.2745086-1-tdevries@suse.de> <20260909094849.2745086-8-tdevries@suse.de> X-Attribution: Tom Date: Fri, 11 Sep 2026 12:48:35 -0600 Message-ID: <87cxujy67w.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1x56Ie-00000002AMz-069U X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:35980 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAdhCJwmsSMZJE57bDqR/gGWUth2XLVX7cvMZf2f1/NhH1mqTIOFr71oeH3t9rLD6/o/EtNhgMS9+byeAaorvTeqjBWh0W1ObeSj5wTrp7OZXt489srE YoEJb0hNrf6UHRMgLPuRZblrktAHiC6jqcWDru/fI3KuAIj5kJmWAj5eTRk6fpknnUI0/VKB2GrpmlXeEtbB+TO+Eq0VGSJiEoo= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> The problem is that tui_find_backward_disassembly_start_address is not able Tom> move past section holes. Tom> Fix this by using the prev section returned by find_pc_section. Tom> + if (prev != nullptr Tom> + && (bfd_section_flags (prev->the_bfd_section) & SEC_ALLOC) != 0) Tom> + { Tom> + /* Skip over section hole and use previous section. */ I suspect this has the same problem as patch 6, where maybe SEC_CODE is more desirable. Tom