From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UQ43KYQ2vmrkLCMAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 06:31:32 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bUY1aY/A; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9DD281E051; Thu, 01 Oct 2026 06:31:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A2C751E033 for ; Thu, 01 Oct 2026 06:31:31 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9B9264BB592B for ; Thu, 1 Oct 2026 10:31:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9B9264BB592B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bUY1aY/A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E43D04BB58F9 for ; Thu, 1 Oct 2026 10:30:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E43D04BB58F9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E43D04BB58F9 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790850647; cv=none; b=h3W+7jXlPmFanVadd8ePUpCDIyiBf0QY62z8npvv+C7Y0beTm0gmD7hOLakYCNK+mIQPxRi92RaxdT+weeW4rOqyvVteIgQdgCSu+XeB5sg/EpB20qi8TRY/3vAUN3WfMJJNDCqG7kN8BFhZB4a2KEPDc6AbMWkC0gl4M9nOxBM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790850647; c=relaxed/simple; bh=/I4L6gmqkaMSYRs+p4RYPb1b+5mBsZIbEKiB59gJLIY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dDZTHj6z3VgWOSj0TcVGJDi24WQqNNR1PibmmUFESY+Ftb9gqk7Kdg7PIEPm3F09ngYSnxpd5+vgLOZrNMMKCJGGT0SGatH+gh18h9eHGsA0l0TCX1HJz5U8r8PQzsbu/XKiwv6ih4eMMnLYXoT2FNpA1XB2nIrGWH+3oUHxOLA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bUY1aY/A DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E43D04BB58F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790850646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+2jOhvIy+pa6kLVWrFK/yotD0+Z2Aku7Em5EM6mO1Sk=; b=bUY1aY/AakIgLdPAf0pHUkxhiN0BW06ipcsVBY3xeyYxE1Xm0urWBDebVpktBKRGEErSCl mQFcdSySOI4B507c1Z5dZmV5KtOF6JBvBLhXJgeYE3ki/zeOI3U8GRppZDJmu3G46IJ0uB Vv2+r8vssmEnbbgMjSNv9Ib2Y7IpP7A= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-1n5S_sG9M7ughbPeawbVHw-1; Thu, 01 Oct 2026 06:30:45 -0400 X-MC-Unique: 1n5S_sG9M7ughbPeawbVHw-1 X-Mimecast-MFC-AGG-ID: 1n5S_sG9M7ughbPeawbVHw_1790850644 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48b09f01f56so434384f8f.1 for ; Thu, 01 Oct 2026 03:30:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790850644; x=1791455444; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=+2jOhvIy+pa6kLVWrFK/yotD0+Z2Aku7Em5EM6mO1Sk=; b=v2vpY4bmKBeukGo8JcwHVlRRSj00W1HYCJmjzL8oQO/X0snj1Z30tKlzxod1/Ody4i Hl6GsiTEzmOnZgHsoL5+t6bLZqITCCd0wbL++z31g+p24d26xC5qjmf1ahO8b/nH4/ho 9gK6XdeXIQ1cfYwpwlYiXMg8e9ExJLiKHpIALQb1bnbu/3Ur+7RzUjWddWeCZbbp7xtQ eXODR2ltcrYb7a2RAMSy0EcUV4zfY0zIW/yafqWL8N6i5xyRlBhNZ2V296yrEGNAGZAt R1GcLRPuQ9hytU+sh4tX9WE8uB4m09JByowK5f5/zjPGRSD2jDEGNJLRaNzfli6uAoSK 14Gw== X-Forwarded-Encrypted: i=1; AKwUvBzKWdnxPaxeRX0XFGu4b0wK6kbtn8heGBzEoQ8XCsbEBh0dVdftWZ4AmnSDAnUh+++xDDr3tmNmBay3Uw==@sourceware.org X-Gm-Message-State: AFuF++l+Mho57T7ZlL7WHhlf3O2otxsMVTeg2q5X6jsNkpfC4v+0H+fM HYoW5p/As+IAx6okGloL6Whx8CFocmJXHj0FGXo87TcWoDKbrqDXg8BNZBNY+mzj+jqhCWdwund 2hfpSKTu7rMuUj8hBOfwNHEYSzzNvy0d7DhV7vqAeykbjGv84OiIm6zLOZ9B/h80feBH05d4= X-Gm-Gg: AYBFou1bpzqI2d7Q4Qzs2HtPoq7anDO4FNZ7MpYgSsDZ4dwlusrWHiwBz5R4GjPa2Gv /v4EtriPBaAppeV6Vc1V2EVOHQ6bKO3ukhVSLRYGjBxZgeMbIra15Egzgg8U7cmMdv9mwfoNEZo NddYh0kE4ecZJiFy9kbfL7fBvskc/QT55Sh9I5bV7XIXX8j+IAEK00yFNisp4xZbp0vhpX9OoBh NfoWqWs8wTI7KDGEfY6PVpkt7ojEFlsPnV8SuF4iDQdQ9c99s9jadJD3xdD8sPTx5KPP4A+Lf0w pWZxORafSZNXaIKDzmIcpwQJCkyae1ZGUNTXrXYiIIU9V+IZW/Yvf67SOkyoRZEddlHl X-Received: by 2002:a05:600c:474e:b0:4a0:1c10:1419 with SMTP id 5b1f17b1804b1-4a01c1032dcmr66447685e9.26.1790850644119; Thu, 01 Oct 2026 03:30:44 -0700 (PDT) X-Received: by 2002:a05:600c:474e:b0:4a0:1c10:1419 with SMTP id 5b1f17b1804b1-4a01c1032dcmr66447135e9.26.1790850643651; Thu, 01 Oct 2026 03:30:43 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a01f91466asm59535675e9.4.2026.10.01.03.30.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2026 03:30:43 -0700 (PDT) From: Andrew Burgess To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH v2 01/11] gdb: add symbol_search_kind enum for global_symbol_searcher In-Reply-To: <20261001020952.698419-2-simon.marchi@polymtl.ca> References: <20260929194119.155169-1-simon.marchi@efficios.com> <20261001020952.698419-2-simon.marchi@polymtl.ca> Date: Thu, 01 Oct 2026 11:30:42 +0100 Message-ID: <87cxttzp9p.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DCvQ0k0u7HBS82avUayoT_T8tv4aNBJLk-QrmKtevLk_1790850644 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I think this is looking good. Just one minor comment inline below: simon.marchi@polymtl.ca writes: > @@ -5166,20 +5179,18 @@ symtab_symbol_info (bool quiet, bool exclude_minsyms, > const char *classname; > switch (kind) > { > - case VAR_DOMAIN: > + case symbol_search_kind::VARIABLE: > classname = "variable"; > break; > - case FUNCTION_DOMAIN: > + case symbol_search_kind::FUNCTION: > classname = "function"; > break; > - case TYPE_DOMAIN: > + case symbol_search_kind::TYPE: > classname = "type"; > break; > - case MODULE_DOMAIN: > + case symbol_search_kind::MODULE: > classname = "module"; > break; > - default: > - gdb_assert_not_reached ("invalid domain enum"); > } I initially wrote: please don't drop the default case, but then I checked the V1 review and saw this change was made specifically to address the feedback there. What I don't understand is you said: > > I think we could drop the "default" case as part of this refactoring. All > > cases are handled; we lose compile time warnings for unhandled cases with > > the "default" case. > > Agreed that we can drop the default. Note that we don't build with > -Wswitch, but we specifically enable it locally here and there. If the warning is mostly off, including here, then deleting the default seems like the wrong choice. I'm not too fussed, I think there's a middle group, that would keep my happy: 1. initialise classname to nullptr, and 2. follow this switch statement with: gdb_assert (classname != nullptr); Even with the warning on it doesn't protect us from random garbage being cast to type symbol_search_kind and then passed to this function, which the 'default:' case does protect against. But the trailing assert is probably better anyway as it ensures each switch case is doing what needs to be done. With that: Approved-By: Andrew Burgess Thanks, Andrew