From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: preserve shell command exit status in pipe command on EPIPE
Date: Wed, 14 Oct 2026 06:46:32 -0600 [thread overview]
Message-ID: <87cxtc5u1j.fsf@tromey.com> (raw)
In-Reply-To: <20261013171340.1748775-2-simon.marchi@efficios.com> (Simon Marchi's message of "Tue, 13 Oct 2026 13:13:31 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> Work around this by flusing the stream explicitly before calling pclose,
Simon> ignoring errors. With that out of the way, pclose returns the exit
Simon> status of the shell command. This makes something like "pipe COMMAND |
Simon> head -1" behave like it would in a shell.
Looks good.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2026-10-14 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 17:13 [PATCH 1/2] gdb: don't let SIGPIPE kill GDB in the pipe command Simon Marchi
2026-10-13 17:13 ` [PATCH 2/2] gdb: preserve shell command exit status in pipe command on EPIPE Simon Marchi
2026-10-14 12:46 ` Tom Tromey [this message]
2026-10-14 9:32 ` [PATCH 1/2] gdb: don't let SIGPIPE kill GDB in the pipe command Aditya Kamath
2026-10-14 12:42 ` Tom Tromey
2026-10-14 12:56 ` Simon Marchi
2026-10-14 12:46 ` Tom Tromey
2026-10-14 12:57 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cxtc5u1j.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox