Re: [PATCH v2] Fix crash when target-wide-charset doesn't match wchar_t size

[Tom Tromey <tom@tromey.com>]

>>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes:

> Then debug with GDB and we get the crash

>   (gdb) b wchar.c:44
>   (gdb) run
>   (gdb) set target-wide-charset UTF-16
>   (gdb) print single

>   Fatal signal: Segmentation fault
>   ----- Backtrace -----

Could you show the backtrace?  I don't know if I can reproduce this but
I am also curious to know how it happens.

> +static int
> +wide_charset_width (const char *name)
> +{
> +  if (strncasecmp (name, "UTF-16", 6) == 0
> +      || strncasecmp (name, "UCS-2", 5) == 0)
> +    return 2;
> +  if (strncasecmp (name, "UTF-32", 6) == 0
> +      || strncasecmp (name, "UCS-4", 5) == 0)
> +    return 4;
> +  return 0;

I somewhat suspect we should have a different fix targeting the crash
itself.  But I'm not totally sure.

Tom