From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10316 invoked by alias); 22 Jun 2012 20:40:26 -0000 Received: (qmail 10308 invoked by uid 22791); 22 Jun 2012 20:40:25 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Jun 2012 20:40:13 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5MKe4l6028042 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Jun 2012 16:40:04 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5MKe3bV004761 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 22 Jun 2012 16:40:03 -0400 From: Tom Tromey To: "Metzger\, Markus T" Cc: Jan Kratochvil , "kettenis\@gnu.org" , "gdb-patches\@sourceware.org" , "markus.t.metzger\@gmail.com" Subject: Re: [PATCH 06/16] configure: add check for perf_event header References: <1337772151-20265-1-git-send-email-markus.t.metzger@intel.com> <1337772151-20265-7-git-send-email-markus.t.metzger@intel.com> <20120530204240.GF20633@host2.jankratochvil.net> Date: Fri, 22 Jun 2012 20:40:00 -0000 In-Reply-To: (Markus T. Metzger's message of "Thu, 31 May 2012 15:33:04 +0000") Message-ID: <87bokbf5ct.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00736.txt.bz2 >>>>> "Markus" == Metzger, Markus T writes: Markus> Thanks for your review! >> > +AC_CHECK_HEADERS(linux/perf_event.h) Jan> There is already existing big AC_CHECK_HEADERS block at line 1014. Markus> This new check is right at the end of that block. They got expanded by Markus> conditional include statements. It is better to just put the new file into the big AC_CHECK_HEADERS invocation, if possible, since that results in a smaller configure file. Right now you have added a separate AC_CHECK_HEADERS invocation, but it doesn't need to be separate. Tom