From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12105 invoked by alias); 25 Jul 2012 17:38:37 -0000 Received: (qmail 12017 invoked by uid 22791); 25 Jul 2012 17:38:36 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jul 2012 17:38:19 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6PHcHps029835 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Jul 2012 13:38:17 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6PHcGGd003981 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 25 Jul 2012 13:38:17 -0400 From: Tom Tromey To: Khoo Yit Phang Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4]: Enable readline under "python" References: Date: Wed, 25 Jul 2012 17:38:00 -0000 In-Reply-To: (Khoo Yit Phang's message of "Mon, 16 Jul 2012 17:04:16 -0400") Message-ID: <87boj3ivw7.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00558.txt.bz2 >>>>> "Yit" == Khoo Yit Phang writes: Yit> 1) either reimplement the readline module that carefully swaps Yit> configurations between GDB and Python; 2) or run Python's readline in Yit> a separate controlling terminal with a proxy readline module in GDB. #2 seems extremely hard. Maybe #1 is possible, I don't know. Yit> 2012-07-16 Khoo Yit Phang Yit> Enable readline in Python in a GDB-specific way and block the Yit> standard Python readline module to prevent conflicts with GDB. Yit> * Makefile.in (SUBDIR_PYTHON_OBS): Add py-gdb-readline.o. Yit> (SUBDIR_PYTHON_SRCS): Add python/py-gdb-readline.c. Yit> (py-gdb-readline.o): Add rule to compile python/py-gdb-readline.c. Yit> * python/py-gdb-readline.c: New file. Yit> * python/python-internal.h (gdbpy_initialize_gdb_readline): New Yit> prototype. Yit> * python/python.c (_initialize_python): Call Yit> gdbpy_initialize_gdb_readline. This one is ok; but of course it depends on an earlier patch so it can't go in until that is resolved. Tom