From: Tom Tromey <tromey@redhat.com>
To: Ralf Corsepius <ralf.corsepius@googlemail.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: gdb-7.5 branch ready for first release?
Date: Wed, 08 Aug 2012 20:47:00 -0000 [thread overview]
Message-ID: <87boilf6x6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <50201D0C.50005@gmail.com> (Ralf Corsepius's message of "Mon, 06 Aug 2012 21:37:48 +0200")
>>>>> "Ralf" == Ralf Corsepius <ralf.corsepius@googlemail.com> writes:
Ralf> Would such a patch be acceptable or is using inttypes.h/stdint.h being
Ralf> considered a "no-go"?
I can't speak to the sim changes.
For this one:
Ralf> diff --git a/gdb/symfile.c b/gdb/symfile.c
Ralf> index 01252e2..01720fa 100644
Ralf> --- a/gdb/symfile.c
Ralf> +++ b/gdb/symfile.c
Ralf> @@ -2889,8 +2889,8 @@ allocate_symtab (const char *filename, struct objfile *objfile)
Ralf> last_objfile_name);
Ralf> }
Ralf> fprintf_unfiltered (gdb_stdlog,
Ralf> - "Created symtab 0x%lx for module %s.\n",
Ralf> - (long) symtab, filename);
Ralf> + "Created symtab 0x%p for module %s.\n",
Ralf> + symtab, filename);
Ralf> }
Rather than %p I think it is the norm in gdb to use %s with
host_address_to_string.
Tom
next prev parent reply other threads:[~2012-08-08 20:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 13:45 Joel Brobecker
2012-08-03 17:43 ` Tom Tromey
2012-08-06 1:42 ` Joel Brobecker
2012-08-06 8:28 ` Jan Kratochvil
2012-08-06 13:12 ` Joel Brobecker
2012-08-06 14:35 ` Luis Gustavo
2012-08-16 20:07 ` Joel Brobecker
2012-08-16 20:34 ` Tom Tromey
2012-08-16 22:36 ` Joel Brobecker
2012-08-06 19:38 ` Ralf Corsepius
2012-08-08 20:47 ` Tom Tromey [this message]
2012-08-09 4:44 ` Ralf Corsepius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87boilf6x6.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ralf.corsepius@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox