From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17800 invoked by alias); 13 Sep 2012 20:17:01 -0000 Received: (qmail 17789 invoked by uid 22791); 13 Sep 2012 20:16:59 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Sep 2012 20:16:43 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8DKGfOY025980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Sep 2012 16:16:42 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8DKGe1S029754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 13 Sep 2012 16:16:41 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 1/2] MI notification on tsv created and deleted. References: <1347434118-10931-1-git-send-email-yao@codesourcery.com> <1347434118-10931-2-git-send-email-yao@codesourcery.com> Date: Thu, 13 Sep 2012 20:17:00 -0000 In-Reply-To: <1347434118-10931-2-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Wed, 12 Sep 2012 15:15:17 +0800") Message-ID: <87boh93cgn.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00253.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> * mi/mi-interp.c: Declare mi_tsv_created and mi_tsv_deleted. Yao> (mi_interpreter_init): Call observer_attach_tsv_created and Yao> observer_attach_tsv_deleted. Yao> (mi_tsv_created, mi_tsv_deleted): New. Yao> * tracepoint.c (delete_trace_state_variable): Call Yao> observer_notify_tsv_deleted. Yao> (trace_variable_command): Call observer_notify_tsv_created. Yao> (delete_trace_variable_command): Call Yao> observer_notify_tsv_deleted. Yao> (create_tsv_from_upload): Call observer_notify_tsv_created. Yao> * NEWS: Mention it. Yao> gdb/testsuite: Yao> gdb.trace/mi-tsv-changed.exp: New. Looks good to me. Tom