[patch] cleanup: Wunused corefile.c

Aleksandar Ristovski
2013-01-31T19:36:15Z

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Hello,

In addition to already posted/committed Wunused I have a bunch of
patches which work around unused vars by adding attribute unused.

Rationale was: either it was unclear whether the assignment might have
side-effects or there was something that should have been done (e.g.
this case) with the variable.

Let me know if this is acceptable approach.

Thank you,

Aleksandar Ristovski
QNX Software Systems

ChangeLog:

* corefile.c (reopen_exec_file): Add unused attribute to res,
add FIXME comment for future cleanup.

[-- Attachment #2: Wunused-corefile-201301311429.patch --]
[-- Type: text/x-patch, Size: 755 bytes --]

Index: gdb/corefile.c
===================================================================
RCS file: /cvs/src/src/gdb/corefile.c,v
retrieving revision 1.71
diff -u -p -r1.71 corefile.c
--- gdb/corefile.c 14 Jan 2013 21:03:54 -0000 1.71
+++ gdb/corefile.c 30 Jan 2013 22:25:14 -0000
@@ -136,7 +136,7 @@ void
reopen_exec_file (void)
{
char *filename;
- int res;
+ int res __attribute__ ((unused));
struct stat st;
struct cleanup *cleanups;

@@ -149,6 +149,8 @@ reopen_exec_file (void)
cleanups = make_cleanup (xfree, filename);
res = stat (filename, &st);

+ /* FIXME: error checking using 'res' (and remove attribute unused). */
+
if (exec_bfd_mtime && exec_bfd_mtime != st.st_mtime)
exec_file_attach (filename, 0);
else