From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20280 invoked by alias); 12 Mar 2013 20:02:54 -0000 Received: (qmail 20272 invoked by uid 22791); 12 Mar 2013 20:02:53 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 20:02:49 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2CK2mn2016800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Mar 2013 16:02:48 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2CK2l2C015594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 12 Mar 2013 16:02:47 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH v3 12/15] Write tracepoint definition in CTF and read. References: <1362800844-27940-1-git-send-email-yao@codesourcery.com> <1362800844-27940-13-git-send-email-yao@codesourcery.com> Date: Tue, 12 Mar 2013 20:02:00 -0000 In-Reply-To: <1362800844-27940-13-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Sat, 9 Mar 2013 11:47:21 +0800") Message-ID: <87boaoe68p.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00550.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2013-03-08 Yao Qi Yao> * ctf.c (CTF_EVENT_ID_TP_DEF): New macro. Yao> ctf_write_header): Define event type "tp_def" in metadata. Yao> (ctf_write_uploaded_tp): Write tracepoint definition to CTF. Yao> (SET_ARRAY_FIELD, SET_STRING_FIELD): New macros. Yao> (ctf_read_tp): New. Yao> (ctf_open): Call ctf_read_tp. Adjust the event id checking. Yao> Call merge_uploaded_tracepoints. This looks good to me, with one tiny nit: Yao> + is about all aspects of a uploaded tracepoint. Note that the "an uploaded". Tom