From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24500 invoked by alias); 15 May 2013 16:20:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24488 invoked by uid 89); 15 May 2013 16:20:50 -0000 X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_RG autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 16:20:49 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4FGKm5l010332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 May 2013 12:20:48 -0400 Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4FGKkMV000617 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 15 May 2013 12:20:47 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 05/28] py-cmd.c error-checking bug fix References: <87ehe638ww.fsf@fleche.redhat.com> <87fvym1tmo.fsf@fleche.redhat.com> <5193B15C.8080907@redhat.com> Date: Wed, 15 May 2013 16:20:00 -0000 In-Reply-To: <5193B15C.8080907@redhat.com> (Pedro Alves's message of "Wed, 15 May 2013 17:01:32 +0100") Message-ID: <87bo8c2p0h.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00544.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 04/19/2013 03:29 PM, Tom Tromey wrote: >> diff --git a/gdb/python/py-cmd.c b/gdb/python/py-cmd.c >> index 3da9960..ca9e415 100644 >> --- a/gdb/python/py-cmd.c >> +++ b/gdb/python/py-cmd.c >> @@ -668,6 +668,8 @@ gdbpy_string_to_argv (PyObject *self, PyObject *args) >> return NULL; >> >> py_argv = PyList_New (0); >> + if (py_argv == NULL) >> + return NULL; >> Pedro> Shouldn't this be 'malloc_failure (0)' instead of returning NULL? In the Python layer we follow Python conventions for error handling. Here, PyList_New failed and set the Python exception. We just propagate that to our caller. Tom