From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31017 invoked by alias); 16 May 2013 18:16:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30984 invoked by uid 89); 16 May 2013 18:16:32 -0000 X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 16 May 2013 18:16:32 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4GIGUYL018225 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 May 2013 14:16:30 -0400 Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4GIGTV3005001 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 16 May 2013 14:16:30 -0400 From: Tom Tromey To: Phil Muldoon Cc: "gdb-patches\@sourceware.org" Subject: Re: [patch] Convert frame_stash to a hash table References: <5194DA88.6020705@redhat.com> <871u9711nn.fsf@fleche.redhat.com> <5194EA6F.2000104@redhat.com> Date: Thu, 16 May 2013 18:16:00 -0000 In-Reply-To: <5194EA6F.2000104@redhat.com> (Phil Muldoon's message of "Thu, 16 May 2013 15:17:19 +0100") Message-ID: <87bo8azt6r.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00639.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> + if (! f_id.stack_addr_p || ! f_id.code_addr_p || ! f_id.special_addr_p) Phil> + gdb_assert ("Cannot calculate hash for frame_id."); This is still incorrect. Tom