From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7407 invoked by alias); 29 Jul 2013 17:48:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7385 invoked by uid 89); 29 Jul 2013 17:48:51 -0000 X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_50,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 29 Jul 2013 17:48:50 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6THmeEY009265 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 29 Jul 2013 13:48:41 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r6THmdhR013633 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 29 Jul 2013 13:48:40 -0400 From: Tom Tromey To: Michael Eager Cc: Keith Seitz , "gdb-patches\@sourceware.org ml" Subject: Re: [PATCH] Revised display-linkage-name References: <519D086A.50105@eagerm.com> <51BF47DB.6070709@eagerm.com> <51DD891D.7090009@eagerm.com> <51DF3F97.90805@redhat.com> <51E07263.6080605@eagerm.com> <51E6E797.30709@eagerm.com> <51ED705A.5000601@redhat.com> <51ED90E3.30801@eagerm.com> <51EDAA3A.5090504@redhat.com> <51EFF8F8.6050807@eagerm.com> <874nbhtb80.fsf@fleche.redhat.com> <51F2D975.3060801@eagerm.com> Date: Mon, 29 Jul 2013 17:48:00 -0000 In-Reply-To: <51F2D975.3060801@eagerm.com> (Michael Eager's message of "Fri, 26 Jul 2013 13:17:57 -0700") Message-ID: <87bo5lp895.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00724.txt.bz2 >>>>> "Michael" == Michael Eager writes: Tom> FWIW there isn't much need to add new annotations. Annotations are Tom> officially deprecated. It's fine by me if you want to leave this in for Tom> some reason though. Michael> I added the annotations at your request (4/19/13): Tom>> I think for MI it is better to make this a real field. Tom>> Also I wonder whether this should be emitted unconditionally if Tom>> mi-like. Say: Michael> Perhaps I misunderstood what you meant by "make this a real field". Yeah, I'm sorry I wasn't clearer. "annotations" refers to annotate.[ch] and the corresponding command-line option. This is an old way to communicate gdb state changes to a GUI, mainly Emacs. By "a real field" I meant using ui_out_*. Michael> + ui_out_text (uiout, linkname); Tom> This is emitting the linkage name using ui_out_text. That is wrong for Tom> MI. It maybe wasn't clear but I was referring to the quoted line above when I said this. Michael> What should it be? ui_out_field_string()? Something else? Yes, ui_out_field_string. Tom