From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10376 invoked by alias); 15 Oct 2013 13:54:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10343 invoked by uid 89); 15 Oct 2013 13:54:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2013 13:54:10 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9FDs8wP018768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 15 Oct 2013 09:54:08 -0400 Received: from barimba (ovpn-113-54.phx2.redhat.com [10.3.113.54]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9FDs7O0016498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 15 Oct 2013 09:54:07 -0400 From: Tom Tromey To: "Blanc\, Nicolas" Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH v16 3/5] 'add-symbol-file' should update the current target sections. References: <1381148820-21890-1-git-send-email-nicolas.blanc@intel.com> <1381148820-21890-4-git-send-email-nicolas.blanc@intel.com> <874n8o6f66.fsf@fleche.redhat.com> <388084C8C1E6A64FA36AD1D656E4856624373405@IRSMSX106.ger.corp.intel.com> Date: Tue, 15 Oct 2013 13:54:00 -0000 In-Reply-To: <388084C8C1E6A64FA36AD1D656E4856624373405@IRSMSX106.ger.corp.intel.com> (Nicolas Blanc's message of "Tue, 15 Oct 2013 13:37:24 +0000") Message-ID: <87bo2qzlkx.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00455.txt.bz2 >>>>> "Nicolas" == Blanc, Nicolas writes: Nicolas> I rewrote add_target_section_of_objfile using add_target_sections. The Nicolas> new code needs to construct on the heap a temporary array of target Nicolas> sections for the sole purpose of Nicolas> calling add_target_sections. This is not as neat as the original code Nicolas> in my view. I would prefer moving add_target_sections_of_objfile to Nicolas> exec.c. Would this be ok with you? It's fine to just do whatever you think is cleanest and then say why in the re-send. Thanks. Tom