Re: [PATCH 06/15] Remove simple GDBSERVER uses from common, nat and target

Doug Evans
2014-07-14T18:47:56Z

Gary Benson writes:
> This removes various simple GDBSERVER uses from common, nat and
> target. The simple uses are just cases where the code includes defs.h
> or server.h depending on GDBSERVER. Instead, now the files include
> the headers that they require. Unfortunately we still need to check
> GDBSERVER for some files to decide which gnulib config header to
> import, but this is a step in the right direction.
>
> gdb/
> 2014-07-09 Tom Tromey <tromey@redhat.com>
> Gary Benson <gbenson@redhat.com>
>
> * common/buffer.c: Don't include server.h or defs.h; update
> includes.
> * common/common-utils.c: Don't include server.h or defs.h; update
> includes.
> * common/filestuff.c: Don't include server.h or defs.h; update
> includes.
> * common/filestuff.h: Include stdio.h.
> * common/format.c: Don't include server.h or defs.h; update
> includes.
> * common/gdb_vecs.c: Don't include server.h or defs.h; update
> includes.
> * common/print-utils.c: Don't include server.h or defs.h; update
> includes.
> * common/rsp-low.c: Don't include server.h or defs.h; update
> includes.
> * common/signals.c: Don't include server.h or defs.h; update
> includes.
> * common/vec.c: Don't include server.h or defs.h; update includes.
> * common/xml-utils.c: Don't include server.h or defs.h; update
> includes.
> * nat/linux-osdata.c: Don't include server.h or defs.h; update
> includes.
> * nat/linux-procfs.c: Don't include server.h or defs.h; update
> includes.
> * nat/linux-ptrace.c: Don't include server.h or defs.h; update
> includes.
> * nat/mips-linux-watch.h: Don't include server.h or defs.h; update
> includes.
> * target/waitstatus.c: Don't include server.h or defs.h; update
> includes.

LGTM, one nit:

How about

#include "config.h"

instead of

#include <config.h>
?