Re: [PATCH 13/16] Drop non-prototype C function header variants: 'list' test case

Andreas Arnez
2014-11-12T15:05:13Z

On Wed, Nov 12 2014, Pedro Alves wrote:

> On 10/29/2014 04:00 PM, Andreas Arnez wrote:
>> Remove old-style function header variants from list0.h and list1.c.
>> Fill the removed lines with comments or empty lines, such that the
>> line numbering is undisturbed.
>
> Why is it important that the line numbering is undisturbed?

Changes to the line numbering would require heavy adjustments to
list.exp. Many line numbers are hard-coded, as well as a fair amount of
knowledge about the source code in and around certain lines. Thus the
dependency on the line numbering can not be eliminated so easily here,
and it may not even be a useful goal for a "list" test case. Another
option might be to adjust the literal line numbers in list.exp, but even
that is not as straightforward as it may seem, since the test case
expects certain source lines to be exactly n lines apart.

I'll add the above explanation to the commit message, OK?