From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31617 invoked by alias); 29 Oct 2014 16:22:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31605 invoked by uid 89); 29 Oct 2014 16:22:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Oct 2014 16:22:47 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9TGMhuS021427 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 29 Oct 2014 12:22:43 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9TGMgl9011068 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 29 Oct 2014 12:22:43 -0400 From: Sergio Durigan Junior To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 01/16] Eliminate literal line numbers in so-impl-ld.exp References: <1414597859-12523-1-git-send-email-arnez@linux.vnet.ibm.com> <1414598446-13831-1-git-send-email-arnez@linux.vnet.ibm.com> X-URL: http://blog.sergiodj.net Date: Wed, 29 Oct 2014 16:22:00 -0000 In-Reply-To: <1414598446-13831-1-git-send-email-arnez@linux.vnet.ibm.com> (Andreas Arnez's message of "Wed, 29 Oct 2014 17:00:16 +0100") Message-ID: <87bnoukfql.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00819.txt.bz2 On Wednesday, October 29 2014, Andreas Arnez wrote: > Remove literal line numbers from the regexps in so-impl-ld.exp. Add > appropriate eye-catchers to solib1.c and refer to those instead. Hey Andreas, Thanks a lot for doing this, much appreciated. > gdb/testsuite/ChangeLog: > > * gdb.base/solib1.c: Add eye-catchers. > * gdb.base/so-impl-ld.exp: Match against eye-catchers instead of > literal line numbers. > --- > gdb/testsuite/gdb.base/so-impl-ld.exp | 4 ++-- > gdb/testsuite/gdb.base/solib1.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/so-impl-ld.exp b/gdb/testsuite/gdb.base/so-impl-ld.exp > index 073c3df..03d10a5 100644 > --- a/gdb/testsuite/gdb.base/so-impl-ld.exp > +++ b/gdb/testsuite/gdb.base/so-impl-ld.exp > @@ -61,12 +61,12 @@ gdb_test "next" "21\[ \t\]*result = solib_main .result.;" \ > > # Verify that we can step into the second shlib call. > # > -gdb_test "step" "solib_main .arg=10000. at.*${libfile}.c:17.*" \ > +gdb_test "step" "solib_main .arg=10000. at.*${libfile}.c:.* HERE .*" \ > "step into solib call" Can't you use ${decimal} here, instead of expecting anything? > # Verify that we can step within the shlib call. > # > -gdb_test "next" "18\[ \t\]*\}" "step in solib call" > +gdb_test "next" "\[0-9\]+\[ \t\]*\}.* STEP .*" "step in solib call" Same here: ${decimal} is made to replace this \[0-9\]+. > > # Verify that we can step out of the shlib call, and back out into > # the caller. > diff --git a/gdb/testsuite/gdb.base/solib1.c b/gdb/testsuite/gdb.base/solib1.c > index 2e51750..224a93d 100644 > --- a/gdb/testsuite/gdb.base/solib1.c > +++ b/gdb/testsuite/gdb.base/solib1.c > @@ -14,5 +14,5 @@ int solib_main (arg) > #endif > #endif > { > - return arg*arg; > -} > + return arg*arg; /* HERE */ > +} /* STEP */ > -- > 1.8.4.2 Otherwise, it looks good to me (not an approval). -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/