From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113096 invoked by alias); 8 Apr 2015 05:54:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113085 invoked by uid 89); 8 Apr 2015 05:54:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mail1.asahi-net.or.jp Received: from mail1.asahi-net.or.jp (HELO mail1.asahi-net.or.jp) (202.224.39.197) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Apr 2015 05:54:31 +0000 Received: from sa76r4 (y081184.ppp.asahi-net.or.jp [118.243.81.184]) by mail1.asahi-net.or.jp (Postfix) with ESMTP id 1C16B24696; Wed, 8 Apr 2015 14:54:28 +0900 (JST) Received: from localhost (localhost [127.0.0.1]) by sa76r4 (Postfix) with ESMTP id E26EF31AF; Wed, 8 Apr 2015 14:54:28 +0900 (JST) Received: from sa76r4 ([127.0.0.1]) by localhost (sa76r4.localdomain [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TypCnHnt-ezo; Wed, 8 Apr 2015 14:54:28 +0900 (JST) Received: from sa76r4.ysato.dip.jp (localhost [127.0.0.1]) by sa76r4 (Postfix) with ESMTP id C1C792F23; Wed, 8 Apr 2015 14:54:28 +0900 (JST) Date: Wed, 08 Apr 2015 05:54:00 -0000 Message-ID: <87bniz5fmz.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Mike Frysinger , gdb-patches@sourceware.org Subject: Re: [PATCH][SIM] Add RXv2 simulation In-Reply-To: <20150408030943.GS16816@vapier> References: <87384c7a0v.wl-ysato@users.sourceforge.jp> <20150408030943.GS16816@vapier> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00251.txt.bz2 At Tue, 7 Apr 2015 23:09:43 -0400, Mike Frysinger wrote: > > [1 ] > On 07 Apr 2015 15:00, Yoshinori Sato wrote: > > This patches added new instructions simulation for RX archtecture. > > please add some tests. if you look in sim/testsuite/sim/, you should be able to > copy over something simple like mcore and then write a few basic .s files to > test the new insns. > OK. > just style comments otherwise -- i'm not familiar with the RX ISA > > > + tprintf("sqrt(%g) = %g\n", da, sqrt(da)); > > all calls need a space before the ( > tprintf ("sqrt(%g) = %g\n", da, sqrt (da)); > > this comes up a few times in your patch > > > + /* Less than 0.49999 */ > > GNU style comments have a period at the end followed by two spaces: > /* Less than 0.49999. */ > > this comes up a few times in your patch > > > + whole_bits ++; > > no space before the ++ operator > > this comes up a few times in your patch > > > + while (! (whole_bits & 0x80000000UL)) > > no space after the ! > > > + if (tag) { printf (tag); tag = 0; } > > i guess not really a new problem, but you're changing this code so you might as > well fix it, but this should not be one line Thanks comment. I'll fix next patches. > -mike > [2 Digital signature ] > No public key for 41633B9FE837F581 created at 2015-04-08T12:09:43+0900 using RSA