From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17245 invoked by alias); 19 Jun 2016 20:37:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17236 invoked by uid 89); 19 Jun 2016 20:37:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,UNPARSEABLE_RELAY autolearn=no version=3.3.2 spammy=Gabriel, gabriel, phony, H*r:Unknown X-HELO: layla.krisman.be Received: from Unknown (HELO layla.krisman.be) (176.31.208.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 19 Jun 2016 20:37:41 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (envelope-from ) id 1bEj1L-0005Cj-7L; Sun, 19 Jun 2016 22:08:39 +0200 From: Gabriel Krisman Bertazi To: Pedro Alves Cc: gdb-patches@sourceware.org, sergiodj@redhat.com, dje@google.com Subject: Re: [RESEND PATCH v6 4/5] Include group information to xml syscall files. References: <87shxd1mx2.fsf@oberon.home> <1463713807-11250-1-git-send-email-gabriel@krisman.be> <7adaf517-55f7-8773-749c-767fe0a37406@redhat.com> Date: Sun, 19 Jun 2016 20:37:00 -0000 In-Reply-To: <7adaf517-55f7-8773-749c-767fe0a37406@redhat.com> (Pedro Alves's message of "Fri, 27 May 2016 11:17:58 +0100") Message-ID: <87bn2wc3uf.fsf@oberon.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00321.txt.bz2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 2513 Pedro Alves writes: > On 05/20/2016 04:10 AM, Gabriel Krisman Bertazi wrote: >> Patch 4/5 bounced due to size. Resending with -M to detect renames... > > Thanks, that's the right thing to do, even without bounces. Best is > to adjust the git config to make that the default. > Hi Pedro, Thanks for your comments, > On 05/20/2016 04:10 AM, Gabriel Krisman Bertazi wrote: >> --- /dev/null >> +++ b/gdb/syscalls/apply-defaults.xsl >> @@ -0,0 +1,31 @@ >> + >> + > > Shouldn't this file be GPLv3+ like all other build or source files? Yes, it should. I went with the no-brainer option and copied the copyright header from the syscall files. I fixed it in v7. v7 also includes the changes you suggested below. Please, let me know your thoughts on that one. Thanks, >> We maintain linux-defaults.xml.in, a template file to hold generic group >> information. It is used by the XSL script that parses the architecture >> specific files to generate the final xml files, which are actually >> installed and loaded by GDB. The script is not run during the normal >> build process, only when building in maintainer mode. > >> +@MAINTAINER_MODE_TRUE@%.xml: %.xml.in apply-defaults.xsl linux-defaults= .xml.in >> +@MAINTAINER_MODE_TRUE@ $(XSLTPROC) -o $(SYSCALLS_SRCDIR)/$@ $(SYSCALLS_= SRCDIR)/apply-defaults.xsl $<;\ >> + > > Please always define the rules in the Makefile.in even without > maintainer mode. What you want is force the _dependencies_ when maintain= er > mode is active, but leave them out otherwise. > That would make it possible to force-regenerate the files even when > not using maintainer mode. > > See e.g.,: gdb/Makefile.in: > > $(srcdir)/aclocal.m4: @MAINTAINER_MODE_TRUE@ $(aclocal_m4_deps) > ... > > So that'd be something like: > > %.xml: @MAINTAINER_MODE_TRUE@ %.xml.in apply-defaults.xsl linux-defaults.= xml.in > $(XSLTPROC) -o $(SYSCALLS_SRCDIR)/$@ $(SYSCALLS_SRCDIR)/apply-defaults.x= sl $<;\ > > It'd be convenient to add a rule to regenerate all xml files, something l= ike: > > .PHONY syscall-xml > syscall-xml: $(SYSCALLS_FILES) > > .PHONY clean-syscall-xml > clean-syscall-xml: $(SYSCALLS_FILES) > rm -f $(SYSCALLS_FILES) > > Thanks, > Pedro Alves > > --=20 Gabriel Krisman Bertazi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 818 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXZwKIAAoJEO9pqxSS5VgPC9QP/AxpHrV0ch8lv1ky4X4hIX/V axEntB5hGLjGPL/Ikfyt2NfNrsWwU6MQopZhFAShY8RI63kvLIDTIuIHztFOqRKS w0oasm5k4UBxfs49InEzLLvCyPyFjocXf+2CYOFz1Fxu0rdLsbX5x6qnuZi0JVIM R3rjAnt21TrlX+EKgviAMPOUebDkblsSiKFr2BVTBBlPLxamb3ULJbaQDlzSIFCE SCN4AaqZh3kUmMxKFYOfj0bhgeavNlq8C0FGI4wd/YKAAD1YAkraJguIdHGtKSwE DmGSjIAaxWdhUEP2lqvV8mbKmdmxmp4Dro9kt307mFOF43qn+QLHbqqtm0RukM1f jrn61w51GDEH8zQOLRKEO8j+5SdovsZA+CD/pw2vNvNvD/r8EyH5uJYzqjUisfxl uS7dvQ55TuIbCUCIGnKDSs0BkRwnpY0u+CJvvxD2BQKgioRi2ZyldG261wt+ljI+ +FL8gTOz3Q4M2Kz0rppjPEuMwBGZvmIV68EPM6i1gxzSknpiCdkWeW5WSUrpeQXs t1ySevq6mkhhmFAuvX3qUwJwHMiGAorTynceHilheiTg0mgt+82SKnhUF61MZcgM dVWi7cxB1N6Mefpua7lA+hWRbqoQhzeoyNVHf6iDbWDsriScSASZmsvtl9JpyzQY kDzhL0uxuGTBIFCzTBMg =PnIw -----END PGP SIGNATURE----- --=-=-=--