From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43387 invoked by alias); 22 Sep 2016 19:15:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43372 invoked by uid 89); 22 Sep 2016 19:15:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:4.86_1, H*F:U*tom X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Thu, 22 Sep 2016 19:15:40 +0000 Received: (qmail 7961 invoked by uid 0); 22 Sep 2016 19:15:37 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy5.mail.unifiedlayer.com with SMTP; 22 Sep 2016 19:15:37 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id mjFa1t0062f2jeq01jFdv7; Thu, 22 Sep 2016 13:15:37 -0600 X-Authority-Analysis: v=2.1 cv=Hq7lRSjS c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=GW1xBdLrtEIA:10 a=20KFwNOVAAAA:8 a=K5xFyjXxCDSel7kUzIgA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 174-16-151-161.hlrn.qwest.net ([174.16.151.161]:47542 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bn9T3-0005tR-VD; Thu, 22 Sep 2016 13:15:34 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 3/5] Use std::string, std::vector in rust-lang.c References: <1474566656-15389-1-git-send-email-tom@tromey.com> <1474566656-15389-4-git-send-email-tom@tromey.com> <89b014ab-704c-bb8e-2e1a-6361efa5a644@redhat.com> Date: Thu, 22 Sep 2016 19:24:00 -0000 In-Reply-To: <89b014ab-704c-bb8e-2e1a-6361efa5a644@redhat.com> (Pedro Alves's message of "Thu, 22 Sep 2016 20:02:55 +0100") Message-ID: <87bmzf21bf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bn9T3-0005tR-VD X-Source-Sender: 174-16-151-161.hlrn.qwest.net (pokyo) [174.16.151.161]:47542 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-09/txt/msg00296.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> So I think we should move the variable declaration to the Pedro> initialization line, to avoid default constructing the variable Pedro> and then resetting it afterwards, as the compiler may Pedro> not be smart enough to elide that. I think so too -- I had avoided this on account of earlier objections to this style. Tom