From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45611 invoked by alias); 16 Oct 2016 07:14:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42243 invoked by uid 89); 16 Oct 2016 07:14:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=puzzled, Hx-spam-relays-external:cmgw3, Hx-spam-relays-external:10.0.90.84, H*RU:10.0.90.84 X-HELO: gproxy1.mail.unifiedlayer.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO gproxy1.mail.unifiedlayer.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Oct 2016 07:13:53 +0000 Received: from cmgw3 (cmgw4 [10.0.90.84]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id 7EB29176AB2 for ; Sun, 16 Oct 2016 01:13:51 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id w7Do1t0072f2jeq017Drfp; Sun, 16 Oct 2016 01:13:51 -0600 X-Authority-Analysis: v=2.1 cv=KLfJUj1o c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=2KmVuUoCAeIMVMItw6IA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:37580 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bvfdk-0002Vp-0c; Sun, 16 Oct 2016 01:13:48 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3] Introduce gdb::unique_ptr References: <1476448162-20203-1-git-send-email-palves@redhat.com> <209d21ef-f3cb-6188-8654-943b2254c9b3@redhat.com> Date: Sun, 16 Oct 2016 07:14:00 -0000 In-Reply-To: <209d21ef-f3cb-6188-8654-943b2254c9b3@redhat.com> (Pedro Alves's message of "Fri, 14 Oct 2016 13:50:27 +0100") Message-ID: <87bmyklqac.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bvfdk-0002Vp-0c X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya) [174.16.143.211]:37580 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00468.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> For managing malloc pointers, this adds a gdb::unique_malloc_ptr Pedro> "specialization" with a custom xfree deleter. I found something surprising while using this patch: it can't be used in a .y file, due to the malloc->xmalloc renaming done in the .y.c rule. I puzzled over the error about "unique_xmalloc_ptr" for a while until I remembered this. One option would be to fix up that renaming, maybe something like: - -e 's/\([^x]\)malloc/\1xmalloc/g' \ - -e 's/\([^x_]\)malloc/\1xmalloc/g' \ Another would be to rename the class unique_xmalloc_ptr after all. Tom