From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26450 invoked by alias); 22 Dec 2016 15:29:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26435 invoked by uid 89); 22 Dec 2016 15:29:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:2061e33, H*f:sk:2061e33, Hx-languages-length:636, research X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Thu, 22 Dec 2016 15:29:37 +0000 Received: (qmail 11160 invoked by uid 0); 22 Dec 2016 15:29:36 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy6.mail.unifiedlayer.com with SMTP; 22 Dec 2016 15:29:36 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id P3VY1u00x2f2jeq013VbvQ; Thu, 22 Dec 2016 08:29:36 -0700 X-Authority-Analysis: v=2.1 cv=DKocvU9b c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n5n_aSjo0skA:10 a=20KFwNOVAAAA:8 a=Pu4L6-UgMMKL6f6V6IYA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 75-171-175-27.hlrn.qwest.net ([75.171.175.27]:34910 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cK5JE-0005B8-NE; Thu, 22 Dec 2016 08:29:32 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 7/8] Use unique_xmalloc_ptr in execute_gdb_command References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-8-git-send-email-tom@tromey.com> <878ts2yi5m.fsf@tromey.com> <87inqletsw.fsf@tromey.com> <7f11b7bb-bebb-1cd3-1e92-266638272443@redhat.com> <87vaueuqoh.fsf@tromey.com> <819d6d1b-1afb-277c-3bf4-e8cc5884ac43@redhat.com> <874m1w6mt0.fsf@tromey.com> <2061e336-0e17-fd9a-b746-61f6fa788beb@redhat.com> Date: Thu, 22 Dec 2016 15:29:00 -0000 In-Reply-To: <2061e336-0e17-fd9a-b746-61f6fa788beb@redhat.com> (Pedro Alves's message of "Thu, 22 Dec 2016 15:09:09 +0000") Message-ID: <87bmw4ugmb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cK5JE-0005B8-NE X-Source-Sender: 75-171-175-27.hlrn.qwest.net (pokyo) [75.171.175.27]:34910 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-12/txt/msg00374.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> It looks like the accepted fix upstream to use the C++17 [[nodiscard]] >> attribute; not sure if we can use that somehow. Pedro> Can't see why not, if we put it behind some ATTRIBUTE_NODISCARD or Pedro> some such define. It wasn't obvious to me (and as you can tell I'm not doing much research into this kind of thing lately...) what condition to use. C++17 isn't official yet, and presumably even if we had some value for __cplusplus to check, we'd also have to check for when exactly it was added to g++? Tom