From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24940 invoked by alias); 12 Apr 2017 14:30:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4108 invoked by uid 89); 12 Apr 2017 14:30:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy3.mail.unifiedlayer.com Received: from gproxy3-pub.mail.unifiedlayer.com (HELO gproxy3.mail.unifiedlayer.com) (69.89.30.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 14:30:27 +0000 Received: from cmgw2 (unknown [10.0.90.83]) by gproxy3.mail.unifiedlayer.com (Postfix) with ESMTP id 4F6D14085A for ; Wed, 12 Apr 2017 08:30:27 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id 7SWQ1v0012f2jeq01SWTz9; Wed, 12 Apr 2017 08:30:27 -0600 X-Authority-Analysis: v=2.2 cv=LIwWeNe9 c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=AzvcPWV-tVgA:10 a=A2ACYP1fSKpp2p0krV0A:9 Received: from 75-166-65-226.hlrn.qwest.net ([75.166.65.226]:56276 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cyJHr-0004oM-Qq; Wed, 12 Apr 2017 08:30:23 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 16/17] Add a constructor and destructor to linespec_result References: <20170411150112.23207-1-tom@tromey.com> <20170411150112.23207-17-tom@tromey.com> Date: Wed, 12 Apr 2017 14:30:00 -0000 In-Reply-To: (Simon Marchi's message of "Tue, 11 Apr 2017 22:25:29 -0400") Message-ID: <87bms17l6p.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cyJHr-0004oM-Qq X-Source-Sender: 75-166-65-226.hlrn.qwest.net (bapiya) [75.166.65.226]:56276 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-04/txt/msg00335.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2017-04-11 11:01, Tom Tromey wrote: >> linespec_result is only ever allocated on the stack, so it's >> relatively easy to convert to having a constructor and a destructor. >> This patch makes this change. This removes some cleanups. Simon> LGTM, though there are still some references in comments to Simon> destroy_linespec_result that could be cleaned up. I've changed these to refer to the linespec_result destructor instead. Tom