From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43952 invoked by alias); 19 Apr 2017 09:01:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43026 invoked by uid 89); 19 Apr 2017 09:01:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=no version=3.3.2 spammy=our, team X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Apr 2017 09:01:26 +0000 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v3J91Omq029431 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Apr 2017 09:01:24 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.13.8/8.14.4) with ESMTP id v3J91NJ6006367 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Apr 2017 09:01:24 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v3J91NUj007992; Wed, 19 Apr 2017 09:01:23 GMT Received: from termi.oracle.com (/10.175.168.176) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 19 Apr 2017 02:01:22 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Pedro Alves Cc: vladimir.mezentsev@oracle.com, gdb-patches@sourceware.org Subject: Re: [PATCH] gdb passes and returns incorrect values when dealing with small array on Sparc References: <1490804220-92717-1-git-send-email-vladimir.mezentsev@oracle.com> <87zifdjti2.fsf@oracle.com> <46e1e493-e787-c4c2-e717-3619e5d9f5ee@redhat.com> Date: Wed, 19 Apr 2017 09:01:00 -0000 In-Reply-To: <46e1e493-e787-c4c2-e717-3619e5d9f5ee@redhat.com> (Pedro Alves's message of "Tue, 18 Apr 2017 23:20:33 +0100") Message-ID: <87bmrsixeq.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00551.txt.bz2 > We (the Oracle toolchain team) actually review the GDB patches > internally from a functional perspective before they are sent upstream. > > We can make it more explicit in our future submissions with a note in > the patch submission. Internal review is of course fine and appreciated, but I still think it better to do at least some of it in the open. Yeah, I agree: the more done in the open the better.