From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72356 invoked by alias); 23 Sep 2017 04:03:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72323 invoked by uid 89); 23 Sep 2017 04:03:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy7-pub.mail.unifiedlayer.com Received: from gproxy7-pub.mail.unifiedlayer.com (HELO gproxy7-pub.mail.unifiedlayer.com) (70.40.196.235) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Sep 2017 04:03:09 +0000 Received: from cmgw2 (unknown [10.0.90.83]) by gproxy7.mail.unifiedlayer.com (Postfix) with ESMTP id 0CA5B215C2E for ; Fri, 22 Sep 2017 22:03:08 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id Cs341w0192f2jeq01s37wi; Fri, 22 Sep 2017 22:03:08 -0600 X-Authority-Analysis: v=2.2 cv=dZfw5Tfe c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=20KFwNOVAAAA:8 a=qR5a7k74RszdzBwh6vYA:9 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:39022 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dvbei-002UrI-L7; Fri, 22 Sep 2017 22:03:04 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 38/67] Constify some linespec functions References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-39-tom@tromey.com> <3ee0e33a-422c-a0f0-33aa-e8c4aa207407@redhat.com> Date: Sat, 23 Sep 2017 04:03:00 -0000 In-Reply-To: <3ee0e33a-422c-a0f0-33aa-e8c4aa207407@redhat.com> (Pedro Alves's message of "Thu, 21 Sep 2017 11:04:01 +0100") Message-ID: <87bmm2hxjc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dvbei-002UrI-L7 X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya) [75.166.76.94]:39022 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-09/txt/msg00716.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> In several places you followed a pattern like: >> static void >> -foo_command (char *args, int from_tty) >> +foo_command (char *args_in, int from_tty) Pedro> ... and then args_in wasn't used. Hmm... normally I think it should be used. Like in this patch (#38): -info_scope_command (char *args, int from_tty) +info_scope_command (char *args_in, int from_tty) ... - char *save_args = args; + const char *save_args = args_in; ... + const char *args = args_in; Pedro> I'd be nice to mention in the commit log the reason for this. Pedro> I assume that it's because we don't have the corresponding Pedro> constified add_cmd variant? In this case I believe the reason is that info_scope_command could not be constified yet, because add_info isn't constified; but on the other hand it calls string_to_event_location, which is now constified, and it didn't seem worthwhile to overload that. I think all the cases *should* be things like this, but of course there may be errors. Tom