From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101338 invoked by alias); 28 Sep 2017 19:57:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100783 invoked by uid 89); 28 Sep 2017 19:57:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:314 X-HELO: gproxy10-pub.mail.unifiedlayer.com Received: from gproxy10-pub.mail.unifiedlayer.com (HELO gproxy10-pub.mail.unifiedlayer.com) (69.89.20.226) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 19:57:36 +0000 Received: from cmgw4 (unknown [10.0.90.85]) by gproxy10.mail.unifiedlayer.com (Postfix) with ESMTP id EC87B1404A7 for ; Thu, 28 Sep 2017 13:57:34 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id F7xX1w00h2f2jeq017xa84; Thu, 28 Sep 2017 13:57:34 -0600 X-Authority-Analysis: v=2.2 cv=OZLoNlbY c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=20KFwNOVAAAA:8 a=uZTBe7FHFmO8tqBSF_UA:9 a=_RM7nvDVKvkA:10 Received: from 75-166-0-208.hlrn.qwest.net ([75.166.0.208]:43012 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dxew7-003SzU-Nb; Thu, 28 Sep 2017 13:57:31 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 02/11] Remove cleanups from mi_cmd_break_insert_1 References: <20170912185736.20436-1-tom@tromey.com> <20170912185736.20436-3-tom@tromey.com> <294ad0fc-6500-2871-42c7-b0414dbdf563@redhat.com> Date: Thu, 28 Sep 2017 19:57:00 -0000 In-Reply-To: <294ad0fc-6500-2871-42c7-b0414dbdf563@redhat.com> (Pedro Alves's message of "Thu, 28 Sep 2017 10:23:55 +0100") Message-ID: <87bmluy4t1.fsf@pokyo> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dxew7-003SzU-Nb X-Source-Sender: 75-166-0-208.hlrn.qwest.net (pokyo) [75.166.0.208]:43012 X-Source-Auth: tom+tromey.com X-Email-Count: 17 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-09/txt/msg00881.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> IMO, it'd be even better to build the std::string directly Pedro> instead of building an obstack and then dupping the string. I made this change. I'll send the new patch a bit later. Tom