From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88018 invoked by alias); 16 Oct 2017 21:50:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88006 invoked by uid 89); 16 Oct 2017 21:50:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:453 X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 21:50:19 +0000 Received: from cmgw4 (unknown [10.0.90.85]) by gproxy6.mail.unifiedlayer.com (Postfix) with ESMTP id EFCBC1E08E4 for ; Mon, 16 Oct 2017 15:50:17 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id NMqE1w01a2f2jeq01MqHEC; Mon, 16 Oct 2017 15:50:17 -0600 X-Authority-Analysis: v=2.2 cv=JNNLi4Cb c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=02M-m0pO-4AA:10 a=0FD05c-RAAAA:8 a=HebIrLqvXdxO2iUeSpYA:9 a=l1rpMCqCXRGZwUSuRcM3:22 Received: from 184-96-33-178.hlrn.qwest.net ([184.96.33.178]:53886 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1e4DH4-0032Nf-Jz; Mon, 16 Oct 2017 15:50:14 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Subject: Re: [RFA 4/6] Simple cleanup removals in remote.c References: <20171016030427.21349-1-tom@tromey.com> <20171016030427.21349-5-tom@tromey.com> <07804bc3-a6c5-2c0f-5730-5dd12fccafbe@ericsson.com> <87fuaipzgg.fsf@tromey.com> Date: Mon, 16 Oct 2017 21:50:00 -0000 In-Reply-To: (Simon Marchi's message of "Mon, 16 Oct 2017 17:36:45 -0400") Message-ID: <87bml6pxt8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1e4DH4-0032Nf-Jz X-Source-Sender: 184-96-33-178.hlrn.qwest.net (pokyo) [184.96.33.178]:53886 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-10/txt/msg00477.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> In any case, I don't really mind, your version is good too and eliminates the Simon> clean up, which is the main point. I guess I'll leave it then, since it's already tested. I'm not always sure what to do in this situation; I guess for me it depends on how strong I perceive your (the reviewer's) opinions to be. thanks, Tom