From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35241 invoked by alias); 13 Jul 2018 20:49:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35232 invoked by uid 89); 13 Jul 2018 20:49:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=boy X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.64.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jul 2018 20:49:33 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway20.websitewelcome.com (Postfix) with ESMTP id B6551400DC715 for ; Fri, 13 Jul 2018 15:49:31 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id e509fD1nGSjJAe50If0ncu; Fri, 13 Jul 2018 15:49:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZrCzcrMNQD40afBs4QVkW3V7i9murWxCjMZ3IO42CsA=; b=hnABHniHQgYEqvoeVQh39SwSIL 8FbyBidukhyoI697V984W+h8EwSDHw4+HYeJwo61dPg30tx6GUC4vZ75WTAhAjF0wz7BcVP7UvXm1 LvygWDmJSLTf8ZIl92Cgt5TqY; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:34522 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fe509-001TE1-Ga; Fri, 13 Jul 2018 15:49:17 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Subject: Re: [RFA 06/13] Remove dead code from m32c-tdep.c References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-7-tom@tromey.com> <7b6df05d-0a2d-4ec5-7b32-91ba9e919250@ericsson.com> Date: Fri, 13 Jul 2018 20:49:00 -0000 In-Reply-To: <7b6df05d-0a2d-4ec5-7b32-91ba9e919250@ericsson.com> (Simon Marchi's message of "Thu, 12 Jul 2018 18:17:36 -0400") Message-ID: <87bmbac14j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00431.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I'm unsure about this one. Boy, I really misread this code. Good thing I broke this one out. Simon> So maybe the safe thing to do would be to make mark_dma return void, and get Simon> rid of the local variables and assignments (but keep the DMA(...) calls). Yep. Tom