From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118588 invoked by alias); 10 Aug 2018 16:13:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118559 invoked by uid 89); 10 Aug 2018 16:13:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=spots X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.164) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Aug 2018 16:13:52 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 5E7C3162BBD for ; Fri, 10 Aug 2018 11:13:51 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id oA2xfNhHhaSeyoA2xfvGcE; Fri, 10 Aug 2018 11:13:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eGRHGmS9/JofczTxU6xVnHrqGsQPeJrHDKkQ4twIeUo=; b=wH9cWdwYUUlxUX92hBPnbLtVmD e8f2OU06IFI/LQLhYh3wLE6H8pD8DgkMHPxSQIEcGYoC/T6d2yf6bSXQNaMw0HuhaUeEejicXq21P nrj76oFD4G0GxDGWSDhZiSKZ+; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:38804 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1foA2x-002qhD-2V; Fri, 10 Aug 2018 11:13:51 -0500 From: Tom Tromey To: Pedro Franco de Carvalho Cc: gdb-patches@sourceware.org, uweigand@de.ibm.com, edjunior@gmail.com Subject: Re: [PATCH v2 01/12] Zero-initialize linux note sections References: <20180810025210.6942-1-pedromfc@linux.ibm.com> <20180810025210.6942-2-pedromfc@linux.ibm.com> Date: Fri, 10 Aug 2018 16:13:00 -0000 In-Reply-To: <20180810025210.6942-2-pedromfc@linux.ibm.com> (Pedro Franco de Carvalho's message of "Thu, 9 Aug 2018 23:51:59 -0300") Message-ID: <87bmaa5hdt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00288.txt.bz2 >>>>> "Pedro" == Pedro Franco de Carvalho writes: Pedro> This patches changes linux-tdep.c so that the buffer used to write Pedro> note sections when generating a core file is zero-initialized. This Pedro> way, bytes that are not collected won't contain random Pedro> data (e.g. padding bytes). Pedro> - char *buf; Pedro> + std::vector buf (size); It might be nice for future developers if there were a comment here explaining that this is intentionally zero-initialized. Other spots in gdb use gdb::def_vector and perhaps someone might think that would be a worthwhile micro-optimization. Tom