From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70371 invoked by alias); 24 Sep 2018 04:58:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70359 invoked by uid 89); 24 Sep 2018 04:58:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Sep 2018 04:58:00 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway22.websitewelcome.com (Postfix) with ESMTP id D0CEBA02C for ; Sun, 23 Sep 2018 23:57:58 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4IwYgnVXpkBj64IwYgwOWG; Sun, 23 Sep 2018 23:57:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mqO6F+Ukv2Bku7CC8utyvS0BbQ/SM42Kx260G6JrXo0=; b=krLuBVg8SRVRywwLpwfmae4I9S u/ujFHHyD/gKubQyVFtmHCMjsWl5Q9aqwWnyHkduGiEIPFjxv6S0mWI0mix1hBYu5i40wIIYZWTGZ T+7oHQahWtUWLbIxumnEBTbks; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:42440 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g4IwY-002wge-Gk; Sun, 23 Sep 2018 23:57:58 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/7] Allow more Python scalar conversions References: <20180915072459.14934-1-tom@tromey.com> <20180915072459.14934-2-tom@tromey.com> <3e15a979-8e98-578a-542c-6318efb8c579@simark.ca> Date: Mon, 24 Sep 2018 04:58:00 -0000 In-Reply-To: <3e15a979-8e98-578a-542c-6318efb8c579@simark.ca> (Simon Marchi's message of "Sun, 23 Sep 2018 22:06:18 -0400") Message-ID: <87bm8nlcfe.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00794.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-09-15 3:24 a.m., Tom Tromey wrote: >> +proc test_float_conversion {} { >> + gdb_test "python print int(gdb.Value(0))" "0" >> + gdb_test "python print int(gdb.Value(0.0))" "0" >> + gdb_test "python print long(gdb.Value(0))" "0" >> + gdb_test "python print long(gdb.Value(0.0))" "0" >> + gdb_test "python print float(gdb.Value(0.0))" "0\\.0" >> + gdb_test "python print float(gdb.Value(0))" "0\\.0" >> +} Simon> This LGTM, but I just wanted to mention that I would probably have tested Simon> with another value than 0. For example, test that the truncation (int(2.3) Simon> which becomes 2) works correctly. Not really a big deal. I've changed the ones with floating point arguments. Tom