From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19348 invoked by alias); 26 Sep 2018 21:44:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19324 invoked by uid 89); 26 Sep 2018 21:44:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.222) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Sep 2018 21:44:57 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway34.websitewelcome.com (Postfix) with ESMTP id CE89D5601CB for ; Wed, 26 Sep 2018 16:44:55 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 5Hc1gfmgw79N35Hc4gojUJ; Wed, 26 Sep 2018 16:44:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wOB/TCTASMtxpfInBffTlYd3uW9UcKCa20hIzyM03qA=; b=aPIiIR7auayT+TqrnD/4kP85MX Nz2Z/Q+TpvK4TaxuJr96dWW0woTJh2pIoPBa8bcK0mP0BPJB7+5vXpI79Og/qLtXGieITt9GAu9hZ EVYvgCsH7CT/YanW7df1brjBJ; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:48094 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g5Hc0-003SS3-KR; Wed, 26 Sep 2018 16:44:48 -0500 From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC 5/6] Do not reopen temporary files References: <20180926111130.18956-1-tom@tromey.com> <20180926111130.18956-6-tom@tromey.com> <83ftxw8i1g.fsf@gnu.org> Date: Wed, 26 Sep 2018 21:44:00 -0000 In-Reply-To: <83ftxw8i1g.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 Sep 2018 17:11:55 +0300") Message-ID: <87bm8kj5m8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00861.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: >> - FILE *out_file = gdb_fopen_cloexec (filename_temp.data (), "wb").release (); >> + gdb_file_up out_file = out_file_fd.to_file ("wb"); Eli> There's a known bug in the MS-Windows (thus MinGW) implementation of Eli> 'fdopen': it ignores the 'b' and 't' flags. So the preceding call to Eli> 'open' must itself specify the O_BINARY flag, or else this replacement Eli> will introduce a subtle bug. Thanks. I think I can pass O_BINARY to mkostemp. Tom