From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111214 invoked by alias); 29 Nov 2018 18:26:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111202 invoked by uid 89); 29 Nov 2018 18:26:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 18:26:57 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 7DEDD4A88F for ; Thu, 29 Nov 2018 12:26:07 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id SR0pg4WIZBcCXSR0pg9L5O; Thu, 29 Nov 2018 12:26:07 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QdEJxltpv9Uctr0KfzRMZ8J7q3UxkaIg7JN8Xz54/0s=; b=dzS9cCN1gzLC8sZ5Emt6LnBnFo owQsf6TNmDr9z90T2T7ElBLS+KpN18Ikv3ED47O6XkckoG0jfWebSDt2fnQ9QyKPletbkjPNEiSmM Ju5bWyTccg4hSJJQl8aPuz2p7; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:32996 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gSR0p-0018rP-8K; Thu, 29 Nov 2018 12:26:07 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Introduce process_stratum_target References: <20181127202247.7646-1-palves@redhat.com> <20181127202247.7646-3-palves@redhat.com> Date: Thu, 29 Nov 2018 18:26:00 -0000 In-Reply-To: <20181127202247.7646-3-palves@redhat.com> (Pedro Alves's message of "Tue, 27 Nov 2018 20:22:46 +0000") Message-ID: <87bm67bv0h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00543.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> This adds a base class that all process_stratum targets inherit from. Pedro> default_thread_address_space/default_thread_architecture only make Pedro> sense for process_stratum targets, so they are transformed to Pedro> process_stratum_target methods/overrides. Pedro> + process_stratum_target () Pedro> + : target_ops {} This struck me as slightly weird -- though not weird enough to block anything. What if I added a protected constructor to target_ops that took the stratum as an argument? Would there be a problem with that? Tom