From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22411 invoked by alias); 30 Dec 2018 23:43:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22401 invoked by uid 89); 30 Dec 2018 23:43:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.250) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 30 Dec 2018 23:43:15 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 33D079A5 for ; Sun, 30 Dec 2018 17:43:14 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dkjigPdOO90ondkjigvXuU; Sun, 30 Dec 2018 17:43:14 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=a2Ke1LnbEXDwlrtPZcAAe9AsNDLNvlYuRYZN5HtFGI0=; b=Vt8J3nm0HfYlR5ClXlO7Ng8q3Z UcVkm8ifq2oRC1lAkr3gP8AJItWw+aVW+8WJOVTH8hu4Tz42JudlsHUdfy3qgUerFt57qu0/I1GoV z6nmGfF9ofWYyari9ES9m3Z6F; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:42180 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gdkjh-003H3U-Vy; Sun, 30 Dec 2018 17:43:14 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Fix leak in most gdb.mi tests. References: <20181229170116.8588-1-philippe.waroquiers@skynet.be> <87a7kom9ez.fsf@tromey.com> <871s60m8lg.fsf@tromey.com> <87wonsktj2.fsf@tromey.com> <1546162107.12900.3.camel@skynet.be> <87k1jrko1a.fsf@tromey.com> <1546205040.12900.14.camel@skynet.be> Date: Sun, 30 Dec 2018 23:43:00 -0000 In-Reply-To: <1546205040.12900.14.camel@skynet.be> (Philippe Waroquiers's message of "Sun, 30 Dec 2018 22:24:00 +0100") Message-ID: <87bm52lgxb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00441.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> The below patch does not put rl inside a gdb::unique_xmalloc_ptr, Philippe> as rl is allocated locally, is then passed as a 'const char*' Philippe> and then xfree-d in the same block. Philippe> Ok to push ? Philippe> Or would it still be better to have a local gdb::unique_xmalloc_ptr ? I think it's better to use a unique_xmalloc_ptr, in case something can throw, either now or in the future. Tom