From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112295 invoked by alias); 12 Jan 2019 16:22:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112281 invoked by uid 89); 12 Jan 2019 16:22:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=nicer X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.160.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Jan 2019 16:22:27 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway30.websitewelcome.com (Postfix) with ESMTP id DCDEC4715 for ; Sat, 12 Jan 2019 10:22:25 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id iM3FgfTXr2qH7iM3FgJfXb; Sat, 12 Jan 2019 10:22:25 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TScoORbkh4n0JwSsK/LLKIzSgwEDGsh+f0uf9y9hGJA=; b=VTTZPPSJeDj4cTzUc+xTW7uiS4 UIy9TODuIrhNVw/Y7Kw2rlrVeaWkLNBQU63y9CJ7+g6c8hcc7aH1/dqEuaS74lDAFGBomOjI1sou1 L3kRerXhcb3T4nYQjFCNj0C7o; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:38088 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1giM3F-0023PZ-Kr; Sat, 12 Jan 2019 10:22:25 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/3] Use function_name_style to print Ada and C function names References: <20190110220113.26169-1-philippe.waroquiers@skynet.be> <20190110220113.26169-2-philippe.waroquiers@skynet.be> Date: Sat, 12 Jan 2019 16:22:00 -0000 In-Reply-To: <20190110220113.26169-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Thu, 10 Jan 2019 23:01:11 +0100") Message-ID: <87bm4lx2v3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00281.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> * ada-typeprint.c (print_func_type): Print function name Philippe> style to print function name. Philippe> * c-typeprint.c (c_print_type_1): Likewise. These are printing type names, not function names -- so I wonder whether we want to apply the function name styling here. Any comments on this aspect? I am not sure myself. On the one hand, it isn't a function name; maybe we would like a type style, but then maybe a type style would be too noisy somehow? On the other hand, maybe calling out function type names looks nicer. Philippe> + fputs_styled (varstring, function_name_style.style (), stream ); Extra space before the close paren. Tom