Re: [PATCH] Minor Ada task cleanups

Tom Tromey
2019-02-19T19:25:20Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> Since this code is used on all platforms and native platforms
Joel> in particular have a lot more testcases that exercise this code,
Joel> it would be nice to exercise it both with the build-bot and
Joel> AdaCore's testsuite.

I ran it through the buildbot as well.

Fedora's buildbot install is broken :-(

https://bugzilla.redhat.com/show_bug.cgi?id=1661951

I had previous made a virtualenv for buildbot, but today the
straightforward approach didn't work. Here's the recipe I ended up
using:

cd ~
python2 -m virtualenv buildbot
. buildbot/bin/activate
pip install buildbot==1.7.0

Joel> Other than that, the patch looks good to me; if the patch with
Joel> the change I suggested passes testing, it's OK to push.

I made the change & I'm going to check it in momentarily.

Tom