From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60411 invoked by alias); 5 Jun 2019 20:47:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60403 invoked by uid 89); 5 Jun 2019 20:47:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1420 X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.97) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Jun 2019 20:47:24 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway31.websitewelcome.com (Postfix) with ESMTP id B187885F60 for ; Wed, 5 Jun 2019 15:47:21 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Ycobh5M1a2qH7YcobhHnJC; Wed, 05 Jun 2019 15:47:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8sZ3ItjcwmvIERsZfnTARL1RoUue/0rrZjj6ibHfWrY=; b=YleJrOH6jfyeGH6Zn9hdLunQ86 CK2dfgo+sQKH1aYX2zCtI4JW89YeW2rCyd61qPbe0DszZF6ZF2COi9VLlYUq5vSnDjGvfuquZvwbx o7kCjSBxWUlkTvXP0yC887VuL; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:40908 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hYcob-0021m1-DN; Wed, 05 Jun 2019 15:47:21 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output) References: <20190605020116.1550-1-tom@tromey.com> <1ee4bd6b-4cdf-f3a9-74af-0843bf123a8b@redhat.com> <87lfygi1x0.fsf@tromey.com> <32872d6a-15d6-9718-59ae-957694e114c9@redhat.com> <87imtjhj6b.fsf@tromey.com> <625cd0ba-058d-d4bf-8ba3-8676f335b0f3@redhat.com> Date: Wed, 05 Jun 2019 20:47:00 -0000 In-Reply-To: <625cd0ba-058d-d4bf-8ba3-8676f335b0f3@redhat.com> (Pedro Alves's message of "Wed, 5 Jun 2019 21:39:38 +0100") Message-ID: <87blzbep47.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00129.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Also, since gcc expects a pointer for %p, and we want to pass an Pedro> enum for the style, I added a small pointer-wrapper hack -- see the Pedro> ptr function. Yay C++. We could just remove the enum, move to passing pointers everywhere, and convert the *_style objects to be pointers. This would streamline things a bit; and we could use nullptr to mean "keep the default". Another option would be to just add a ptr method to the _style objects, so instead of ui_out_style_kind::VARIABLE you'd write variable_style.ptr (). Pedro> I've not been paying much attention to the styling patches, so I can't Pedro> off hand tell which places would benefit the most from this. So I just Pedro> grepped for _styled and replaced a couple spots. Likely there are better Pedro> examples. There's my new patch and I have one more along those lines as well, but a good existing one that was already deconstructed is in symfile.c: puts_filtered (_("Reading symbols from ")); fputs_styled (name, file_name_style.style (), gdb_stdout); puts_filtered ("...\n"); Pedro> For the seemingly common case of printing a string variable Pedro> with a style, I'm thinking that a specific formatter would Pedro> be better. I'll post a follow up patch for that. I'm interested to see it. Tom