From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35531 invoked by alias); 10 Jul 2019 20:57:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35521 invoked by uid 89); 10 Jul 2019 20:57:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.66.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jul 2019 20:57:25 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway20.websitewelcome.com (Postfix) with ESMTP id BB053400C5542 for ; Wed, 10 Jul 2019 14:54:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id lJeWh3vAEiQerlJeWhWYCy; Wed, 10 Jul 2019 15:57:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=V6BvxsGDAhiw/I9G+0m7jgrt48vwsrbDIDjtTispvnM=; b=iSvJNH3XGnP3yWcYKur9rRTP5W 1MykUCoMQWsBZBnCXUkE9ADLeP6MwYabf7EnU2c+/RFjKztpt63Y+gZT7ux3xEfaxJGjpvNgUWhyM nDYinR8tNn7rRaJewpe8Fc3pe; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:52512 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hlJeV-002fIe-QA; Wed, 10 Jul 2019 15:57:23 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Don't include gdbarch.h from defs.h References: <20190614211035.398-1-tom@tromey.com> <0c11d48f648433f9afb55c48798da3ae@polymtl.ca> Date: Wed, 10 Jul 2019 20:57:00 -0000 In-Reply-To: <0c11d48f648433f9afb55c48798da3ae@polymtl.ca> (Simon Marchi's message of "Wed, 10 Jul 2019 15:12:09 -0400") Message-ID: <87bly1d2vg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00285.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2019-06-14 17:10, Tom Tromey wrote: >> I touched symtab.h and was surprised to see how many files were >> rebuilt. I looked into it a bit, and found that defs.h includes >> gdbarch.h, which in turn includes many things. >> >> gdbarch.h is only needed by a minority ofthe files in gdb, so this >> patch removes the include from defs.h and updates the fallout. >> >> I did "wc -l" on the files in build/gdb/.deps; this patch reduces the >> line count from 139935 to 137030; so there are definitely future >> build-time savings here. >> >> Note that while I configured with --enable-targets=all, it's possible >> that some *-nat.c file needs an update. I could not test all of >> these. The buildbot caught a few problems along these lines. Simon> Thanks, I think this makes sense. Thanks. The results came back looking good. It is possible that there could still be a build failure in some untested *-nat.c file. However, these are easily fixed, normally by including gdbarch.h explicitly. So, I'm checking it in now. Tom