From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95639 invoked by alias); 29 Jul 2019 20:21:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95630 invoked by uid 89); 29 Jul 2019 20:21:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SEMBLACK,SPF_HELO_PASS autolearn=no version=3.3.1 spammy=burgess, is_declaration, HX-Spam-Relays-External:sk:gateway, UD:dwarf2read.c X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.199.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Jul 2019 20:21:48 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 639134014B828 for ; Mon, 29 Jul 2019 14:45:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id sC9ThzsMy2qH7sC9Th2FYf; Mon, 29 Jul 2019 15:21:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z8M671XmNaieRnapsWgPwCaveOASI87HJuJABhtPg2g=; b=KVr/GXwL3XxMyOSr7qvhIxqTKo LczYPUTVyRF112L0nPvLwF8wR0NrtOUBbNpQg3tfwHAZIeOY9+RKcpa3sFu62KMnPO86GYYozTbq4 P5eiJVMHa98XT1nMcPJsaYgu/; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:60534 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hsC9S-001zOE-W8; Mon, 29 Jul 2019 15:21:47 -0500 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Richard Bunt Subject: Re: [PATCH 2/7] gdb: Add an is_declaration field to each symbol References: <02a60599e2dff9efead7adbb070733c0f4c65f04.1564243858.git.andrew.burgess@embecosm.com> Date: Mon, 29 Jul 2019 20:21:00 -0000 In-Reply-To: <02a60599e2dff9efead7adbb070733c0f4c65f04.1564243858.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Sat, 27 Jul 2019 17:22:30 +0100") Message-ID: <87blxcpp5y.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00639.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> Track if a symbol is a declaration or not. At one point we could Andrew> possibly figure this out based on the LOC_UNRESOLVED address class of Andrew> the symbol, but, for Fortran we mark some symbols as LOC_UNRESOLVED Andrew> even when the DWARF supplies an address, this is because the address Andrew> supplied by the DWARF is actually wrong. For details look in Andrew> dwarf2read.c and look for references to gFortran bug #40040. I have Andrew> confirmed that current versions of gFortran still have the issue Andrew> mentioned in that bug report. That bug looks like another instance of the copy relocation problem. So, I wonder if these workarounds could be removed if/when this series lands: https://sourceware.org/ml/gdb-patches/2019-06/msg00612.html (I still haven't looked at Pedro's review in detail, but I will get to it sooner or later.) Tom